test: Validate EIP712 patch in tests #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drklee3
requested review from
rhuairahrighairidh,
karzak,
pirtleshell,
nddeluca,
DracoLi,
evgeniy-scherbina,
sesheffield,
boodyvo and
lbayas
as code owners
1 task
pirtleshell
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
🙌
just confirming... no changes are necessary to the e2e version of the EIP712 tests, correct? i don't recall what difference there was that made me recreate the tx building there.... but it is using the new ethermint's change that makes the tx not have a signing domain / salt.
|
Yup no changes needed, just the extra validation on the updated domain fields are empty |
|
@Mergifyio backport master |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
Tests various EIP712Domains in ante tests and assert EIP712 domain verifyingContract & salt fields in e2e tests. This is to ensure our patch has been properly applied and integrated. (cherry picked from commit 8776c95)
1 task
drklee3
pushed a commit
that referenced
this pull request
Nov 4, 2024
) (#2045) Tests various EIP712Domains in ante tests and assert EIP712 domain verifyingContract & salt fields in e2e tests. This is to ensure our patch has been properly applied and integrated. BREAKING CHANGE: This updates EIP712 domain to remove verifyingContract and Salt fields as part of the fix for Metamask signing. This ALSO includes Ethermint commits that are related to precompiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ante test from test(ante): Add test to cover various EIP712Domain fields #2021
Add assertions in e2e test to check updated domain fields
Backport to master branch after merge