chore(deps)!: Update Ethermint and validate EIP712 patch (backport #2044) #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Tests various EIP712Domains in ante tests and assert EIP712 domain verifyingContract & salt fields in e2e tests. This is to ensure our patch has been properly applied and integrated. (cherry picked from commit 8776c95)
mergify
bot
requested review from
rhuairahrighairidh,
karzak,
pirtleshell,
drklee3,
nddeluca,
DracoLi,
evgeniy-scherbina,
sesheffield,
boodyvo and
lbayas
as code owners
1 task
1 task
BREAKING CHANGE: This updates EIP712 domain to remove verifyingContract and Salt fields as part of the fix for Metamask signing. This ALSO includes Ethermint commits that are related to precompiles.
drklee3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ante test from test(ante): Add test to cover various EIP712Domain fields #2021
Add assertions in e2e test to check updated domain fields
Update Ethermint that includes both EIP712 patch and precompiles
Backport to master branch after merge
This is an automatic backport of pull request test: Validate EIP712 patch in tests #2044 done by Mergify.