Add test of gl_VertexID and gl_InstanceID. #3484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdashg
force-pushed
the
no-attrib-array-instancing
branch
2 times, most recently
from
d86d88d
to
839b2d6
Compare
Includes details in new test about both state-of-specification, and known errata. Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1779800
kdashg
force-pushed
the
no-attrib-array-instancing
branch
from
839b2d6
to
e6aac59
Compare
|
@kenrussell You can see the line that we might need to uncomment for now, depending on the state of the ANGLE-on-Metal rollout: Safari seems to pass even with that errata commented out, as does patched Firefox. |
kenrussell
requested changes
Sep 22, 2022
There was a problem hiding this comment.
This doesn't run in Chrome Canary or Firefox Nightly as is:
Uncaught (in promise) TypeError: Failed to execute 'getAttachedShaders' on 'WebGLRenderingContext': parameter 1 is not of type 'WebGLProgram'.
at fn (builtin-vert-attribs.html:234:36)
at builtin-vert-attribs.html:247:28
Could you please investigate and revise?
davychxn
reviewed
Jan 2, 2023
|
|
||
| let fn = (vs) => { | ||
| //console.log({vs}); | ||
| const prog = wtu.setupProgram(gl, [vs, FS]); |
There was a problem hiding this comment.
Here, looks vs, fs should be ids of DOM elements, instead of source shaders, I think.
There was a problem hiding this comment.
Oh, sorry, how careless, missed other branches of if
davychxn
reviewed
Jan 2, 2023
| */ | ||
|
|
||
| const wtu = WebGLTestUtils; | ||
| const gl = wtu.create3DContext('e_canvas'); |
There was a problem hiding this comment.
I think, we should create a webgl2 context here, maybe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes details in new test about both state-of-specification, and known errata.
Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1779800