fix: escaped Unicode in BaseAdapter #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a bug where Unicode in structured
input
andoutput
is escaped in theBaseAdapter
, causing two main issues:input
andoutput
are sent back to the frontend as escaped strings (code reference), which are displayed as-is in theDatasets
page.input
andoutput
are persisted in.kiln
files as ASCII. While valid JSON, this is not ideal for scenarios like collaboration, committing datasets to GitHub, and searching. Additionally, there is a risk of improperly decoding these strings.After this fix, Kiln will store structured
input
andoutput
without escaping Unicode, which is already the behavior for plain textinput
andoutput
. This change is non-breaking, asjson.load
andjson.loads
can handle both Unicode and ASCII-escaped Unicode.Related Issues
Part of a group of bugs caused by escaped Unicode: #95
Contributor License Agreement
I, @leonardmq, confirm that I have read and agree to the Contributors License Agreement.
Checklists