-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added integration test on HTTPS #88
Conversation
1871546
to
4c2319e
Compare
f332864
to
cbdd513
Compare
@czeslavo I factorized a lot of code between the two |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor!
Signed-off-by: Mattia Lavacca <[email protected]>
Co-authored-by: Grzegorz Burzyński <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
f30bebd
to
17ed875
Compare
Tests are failing
|
Signed-off-by: Mattia Lavacca <[email protected]>
17ed875
to
0789bef
Compare
It's fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits which I do not consider blockers for this PR. 👍
What this PR does / why we need it:
a new Integration test on HTTPRoute with HTTPS traffic has been added
Which issue this PR fixes
Fixes #87
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:- [] theCHANGELOG.md
release notes have been updated to reflect significant changes