Support Blueprint mesh in shaping #1455
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version compiles without MFEM, if conduit is supported. But it doesn't run because the conduit side is not fully written yet.
GridFunctionView is renamed TempArrayView to reflect that it doesn't work with just GridFunctions.
…memory' into feature/gunney/blueprint-mesh-shaping
The feature was never used and we are moving away from MFEM mesh in favor of blueprint mesh.
Add blueprint support to shaper code and test code.
The code required what to Blueprint was optional.
Facilitated by ability to reshape array data in sidre Views.
Also add code to save results for visualization.
Taking the allocator from Groups with external data isn't reliable, due to the way we import data. External data may correspond to multiple allocators.
Using Conduit is too slow, due to the need to copy device data to host and back. This change requires a change in the shaper constructors, because the conversion code needs to be told what execution space to run in.
…emory' into feature/gunney/blueprint-mesh-shaping
To be in line with other codes' convention.
Users can provide a memory pool to bypass slow CUDA memory allocations/deallocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IntersectionShaperand the shaper in-memory shape tests #1452IntersectionShaper.IntersectionShaperto make any need to move memory transparent to the calling function. For example, if host functions are need for a computation, device data is copied to host, worked on then copied back to device.quest_shape_in_memory.cpp) to test the Blueprint mesh support.Planned follow-up.
To keep this PR and its companion as as small as possible, I avoided moving code around too much. As a result the code is a bit messy. Issue #1445 tracks the planned follow work.
Motivation
IntersectionShapercurrently support only MFEM mesh. That was due to convenience when the class was developed.IntersectionShaperdoesn't make any use of any features not supported by Blueprint. We need to support Blueprint mesh, as that is the standard for LLNL.