LibJS: Some prepatory commits to begin anew with Temporal #2387
+288
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trflynn89
force-pushed
the
temporal_prep
branch
2 times, most recently
from
13cf01c
to
2427cb3
Compare
The Duration record no longer exists in Temporal. Implement it according to the DurationFormat spec to prepare for its removal from our Temporal implementation. We also implement the DurationSign AO here as well, as the Temporal implementation will now require a Temporal.Duration JS object.
The production for these strings has been removed from Temporal. This implements a separate parser in accordance with the Date spec.
Stop relying on Temporal, at least temporarily. The classes used here will soon be removed (until they are implemented again from scratch).
trflynn89
force-pushed
the
temporal_prep
branch
from
2427cb3
to
cd6d6c3
Compare
The Temporal.TimeZone object no longer exists in the Temporal spec.
We don't need nanosecond precision here anyways, as we only display millisecond resolution. This uses our simple duration formatter from AK, which is updated to accept a Duration here. This method did not have any users after the move from Serenity.
trflynn89
force-pushed
the
temporal_prep
branch
from
cd6d6c3
to
b7233a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits are to prepare us to get caught back up with the Temporal spec. My plan is to basically remove our current Temporal implementation and begin anew. I've tried a few times to make updates in place, but everything in Temporal is so intertwined that I've become convinced that is a non-starter.
So the commits here fall into one of two categories:
No test262 diff here.