Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibJS: Some prepatory commits to begin anew with Temporal #2387

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

LibJS: Some prepatory commits to begin anew with Temporal #2387

wants to merge 6 commits into from
+288 −129

Commits on Nov 18, 2024

  1. LibJS: Remove unused Temporal inclusion from Intl

    @trflynn89
    trflynn89 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    195f922 View commit details
    Browse the repository at this point in the history

  2. LibJS: Remove usage of obsolete Duration record from Intl.DurationFormat 

    The Duration record no longer exists in Temporal. Implement it according
to the DurationFormat spec to prepare for its removal from our Temporal
implementation.

We also implement the DurationSign AO here as well, as the Temporal
implementation will now require a Temporal.Duration JS object.
    @trflynn89
    trflynn89 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    6d7d301 View commit details
    Browse the repository at this point in the history

  3. LibJS: Don't use Temporal to parse UTC offset strings 

    The production for these strings has been removed from Temporal. This
implements a separate parser in accordance with the Date spec.
    @trflynn89
    trflynn89 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    9a479f6 View commit details
    Browse the repository at this point in the history

  4. LibJS: Use Date for timing test-js tests 

    Stop relying on Temporal, at least temporarily. The classes used here
will soon be removed (until they are implemented again from scratch).
    @trflynn89
    trflynn89 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    9f6101a View commit details
    Browse the repository at this point in the history

  5. LibJS: Use an Intl prototype for a Function.prototype.toString test 

    The Temporal.TimeZone object no longer exists in the Temporal spec.
    @trflynn89
    trflynn89 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    6968b80 View commit details
    Browse the repository at this point in the history

  6. AK+LibJS: Don't use Temporal for console.time() and console.timeLog() 

    We don't need nanosecond precision here anyways, as we only display
millisecond resolution.

This uses our simple duration formatter from AK, which is updated to
accept a Duration here. This method did not have any users after the
move from Serenity.
    @trflynn89
    trflynn89 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b7233a7 View commit details
    Browse the repository at this point in the history