Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update way anvil state dump is generated #222

Merged
merged 23 commits into from
Jan 17, 2025
Merged

Conversation

ricomateo
Copy link
Contributor

@ricomateo ricomateo commented Jan 16, 2025

Motivation
The anvil dump state was very outdated. There are some tests that require contracts that weren't deployed in the anvil state (e.g. RewardsCoordinator).

Description
This PR introduces the following changes

  • Fixes and updates the script that generates the anvil state.
  • Fixes the tests that failed as a result of updating the anvil state.
  • Changes the Foundry version used to dump the anvil state to the same version used in the eigensdk-go.
  • Adds MockERC20 to the generated bindings.

@MegaRedHand MegaRedHand marked this pull request as ready for review January 16, 2025 21:37
MegaRedHand
MegaRedHand previously approved these changes Jan 16, 2025
@supernovahs
Copy link
Collaborator

supernovahs commented Jan 16, 2025

wow , wondering how did those 2 tests get passed before and not now. The state json file is not modified here. 😕

edited:ahh its modifed

@supernovahs
Copy link
Collaborator

supernovahs commented Jan 16, 2025

i get this when trying to generate new state. Don't know if it's due to my M1 chip

    │   │   │   └─ ← [Return] 0xDc64a140Aa3E981100a9becA4E685f962f0cF6C9
    │   │   └─ ← [Return] 0xDc64a140Aa3E981100a9becA4E685f962f0cF6C9
    │   └─ ← [Return] 15524 bytes of code
    ├─ [4701] ProxyAdmin::upgradeAndCall(TransparentUpgradeableProxy: [0xc3e53F4d16Ae77Db1c982e75a937B9f60FE63690], MockAvsServiceManager: [0x36C02dA8a0983159322a80FFE9F24b1acfF8B570], 0x485cc955000000000000000000000000f39fd6e51aad88f6f4ce6ab8827279cfffb92266)
    │   ├─ [3306] TransparentUpgradeableProxy::upgradeToAndCall(MockAvsServiceManager: [0x36C02dA8a0983159322a80FFE9F24b1acfF8B570], 0x485cc955000000000000000000000000f39fd6e51aad88f6f4ce6ab8827279cfffb92266)
    │   │   ├─ emit Upgraded(implementation: MockAvsServiceManager: [0x36C02dA8a0983159322a80FFE9F24b1acfF8B570])
    │   │   ├─ [228] MockAvsServiceManager::initialize() [delegatecall]
    │   │   │   └─ ← [Revert] EvmError: Revert
    │   │   └─ ← [Revert] revert: Address: low-level delegate call failed
    │   └─ ← [Revert] revert: Address: low-level delegate call failed
    └─ ← [Revert] revert: Address: low-level delegate call failed


Error: script failed: revert: Address: low-level delegate call failed
Script exited due to set -e on line 57 with command 'forge script script/DeployMockAvs.s.sol --rpc-url $ETH_HTTP_URL --private-key $DEPLOYER_PRIVATE_KEY --broadcast'. Exit status: 1
anvil

@supernovahs
Copy link
Collaborator

if i had to guess, binding issue?

@MegaRedHand MegaRedHand dismissed their stale review January 17, 2025 02:53

CI not passing

@MegaRedHand
Copy link
Contributor

@supernovahs It was an issue with the new MockAvsServiceManager.initialize having now two parameters 🙈
2ede20b

@supernovahs supernovahs merged commit a4a04cd into main Jan 17, 2025
3 checks passed
@MegaRedHand MegaRedHand deleted the update-anvil-state branch January 17, 2025 15:00
@MegaRedHand MegaRedHand changed the title update anvil state chore: update way anvil state dump is generated Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants