Add editorconfig, prettier and sync lint rules with GNOME Shells #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently, ESLint is moving away from stylistic rules so prettier will probably be necessary: https://typescript-eslint.io/troubleshooting/formatting/#eslint-core-and-formatting |
Leleat
force-pushed
the
format-prettier
branch
from
2ec2a0d to
f537dbd
Compare
added 3 commits
August 11, 2024 21:54
The lint rules came from GNOME Shell's repo but have been outdated for a while. So update them now (and transform them to eslint's new flat file format). Only change is that I will always require curly braces as I am not a fan of prettier inlining expressions with something like if clauses.
Leleat
force-pushed
the
format-prettier
branch
from
f537dbd to
017943e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure how I feel about adding prettier yet. I like the general formatting of prettier but a) Tiling Assistant hasn't used it before and b) I've never seen prettier used in a GNOME context before... I'll need to mull it over...