-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web UI migration to Vite and Vue3 and improvements to the UX #1673
Web UI migration to Vite and Vue3 and improvements to the UX #1673
Conversation
I'll take a look at this over the weekend, I am a full stack dev and have experience in Vue so if you need an extra pair of eyes for a code review I'm down for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to pinning dependencies, can you also ensure new lines exist at the end of files?
I haven't dug into the rest of it yet. Would be nice to incorporate #972 into this or a separate PR shortly after this one. The dev of that one hasn't been active, probably easier to recreate their work than rebase the PR now.
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the build comments. Here are a few related to the UI.
Can you add some padding at the bottom of the home page? If it matched the troubleshooting page, I think that would be fine.
On Applications, the "edit" button doesn't work, unless the lower portion is already expanded with the "add new" button
The "x" does not work for the cover finder. Actually, neither does selecting an image. (Clicking off of the modal does close it though)
Add Detached Command button does not work.
Save application does not work for existing applications. I added "test.log" to output, saved, and then edited again, but the field remained blank. Seems to work for new applications.
Configuration seems a little wonky. There is a square around some options, but not others.
Moving to the "Files" tab, the options from general that were not in the box, appear at the top of "Files".
And the files options appear at the bottom in a "cutoff" box.
That behavior continues for the remainder of the tabs. (The non boxed options from "General" appear at the top of each tab.
I did not test any of the buttons in the Configuration section.
Troubleshooting/Logs... can be a separate PR, but could the "Find" feature ignore the case?
I am using Firefox, I don't know if that has any impact on anything. I reloaded the UI with no cache as well.
Lastly, the tray icon has no image.
Tested on Windows 11.
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
Thank you, I've checked everything (paddings, configration page issues, app page issues, missing tray icon) and everything should now be in order |
Co-authored-by: ReenigneArcher <[email protected]>
@TheElixZammuto not sure if you saw my last review. #1673 (comment) That's the only thing I saw not working. It's possible it doesn't work in the current version as well (I didn't check). |
Fixed that (it already worked on app list, only global commands did not work) |
…yte#1673) Co-authored-by: ReenigneArcher <[email protected]>
…yte#1673) Co-authored-by: ReenigneArcher <[email protected]>
TO-DO
npx vite build
after annpm install
)Description
This PR is a big one, but the biggest changes couldn't be split and I did the smallest while fixing the biggest:
Use Vite as a build system for building and bundling the assets, instead of using directly node_modules. This allows us to use npm dependencies like ES modules, and to simplify the deployment of the static assets.
Moved the bundling of the HTML header and content from Sunshine to Vite, using EJS. This allows us to self-host the UI without Sunshine, for testing (we can deploy the UI on GitHub pages e.g.) and for helping with tralsation tools. The shared HTML components (like the header) are now Vue Single File Components
Migrated Vue from version 2 to version 3, with all the breaking changes done
A revamped welcome page, with links to the support and legal directly in the welcome page
Minor fixes to the applications page: now detatched command lists behave in the same way as the do-undo commands
Minor styling changes to the app and PIN pages
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.