Skip to content

chore: fixes from code review

Codecov / codecov/patch failed Jul 4, 2024 in 1s

1.48% of diff hit (target 8.95%)

View this Pull Request on Codecov

1.48% of diff hit (target 8.95%)

Annotations

Check warning on line 19 in src/input/common.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/common.cpp#L18-L19 

Added lines #L18 - L19 were not covered by tests

Check warning on line 23 in src/input/common.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/common.cpp#L23 

Added line #L23 was not covered by tests

Check warning on line 28 in src/input/common.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/common.cpp#L28 

Added line #L28 was not covered by tests

Check warning on line 31 in src/input/common.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/common.cpp#L30-L31 

Added lines #L30 - L31 were not covered by tests

Check warning on line 35 in src/input/common.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/common.cpp#L34-L35 

Added lines #L34 - L35 were not covered by tests

Check warning on line 38 in src/input/common.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/common.cpp#L38 

Added line #L38 was not covered by tests

Check warning on line 42 in src/input/common.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/common.cpp#L42 

Added line #L42 was not covered by tests

Check warning on line 48 in src/input/common.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/common.cpp#L48 

Added line #L48 was not covered by tests

Check warning on line 52 in src/input/common.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/common.cpp#L52 

Added line #L52 was not covered by tests

Check warning on line 24 in src/input/common.h

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/common.h#L23-L24 

Added lines #L23 - L24 were not covered by tests

Check warning on line 39 in src/input/common.h

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/common.h#L39 

Added line #L39 was not covered by tests

Check warning on line 20 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L20 

Added line #L20 was not covered by tests

Check warning on line 24 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L23-L24 

Added lines #L23 - L24 were not covered by tests

Check warning on line 28 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L28 

Added line #L28 was not covered by tests

Check warning on line 34 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L33-L34 

Added lines #L33 - L34 were not covered by tests

Check warning on line 40 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L38-L40 

Added lines #L38 - L40 were not covered by tests

Check warning on line 42 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L42 

Added line #L42 was not covered by tests

Check warning on line 46 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L46 

Added line #L46 was not covered by tests

Check warning on line 63 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L63 

Added line #L63 was not covered by tests

Check warning on line 74 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L74 

Added line #L74 was not covered by tests

Check warning on line 87 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L87 

Added line #L87 was not covered by tests

Check warning on line 99 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L99 

Added line #L99 was not covered by tests

Check warning on line 109 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L109 

Added line #L109 was not covered by tests

Check warning on line 111 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L111 

Added line #L111 was not covered by tests

Check warning on line 116 in src/input/gamepad.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/input/gamepad.cpp#L116 

Added line #L116 was not covered by tests
View more details on Codecov