Skip to content

chore: fixes from code review

Codecov / codecov/project succeeded Jul 4, 2024 in 1s

8.80% (-0.15%) compared to 9b5a046

View this Pull Request on Codecov

8.80% (-0.15%) compared to 9b5a046

Details

Codecov Report

Attention: Patch coverage is 1.48402% with 863 lines in your changes missing coverage. Please review.

Project coverage is 8.80%. Comparing base (9b5a046) to head (1aca214).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2594      +/-   ##
=========================================
- Coverage    8.95%   8.80%   -0.15%     
=========================================
  Files          95     104       +9     
  Lines       17386   17407      +21     
  Branches     8268    8248      -20     
=========================================
- Hits         1557    1533      -24     
- Misses      12961   13154     +193     
+ Partials     2868    2720     -148     
Files Coverage Δ
src/audio.h 0.00% <ø> (ø)
src/config.cpp 4.77% <ø> (ø)
src/entry_handler.cpp 2.47% <ø> (ø)
src/platform/linux/publish.cpp 0.00% <ø> (ø)
src/platform/macos/input.cpp 36.57% <ø> (ø)
src/platform/macos/publish.cpp 4.13% <ø> (ø)
src/platform/windows/publish.cpp 0.00% <ø> (ø)
src/process.cpp 1.35% <ø> (ø)
src/process.h 11.11% <ø> (ø)
src/server/crypto.h 0.00% <ø> (ø)
... and 26 more

... and 13 files with indirect coverage changes