Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-481: Action pulls latest SQL Server (=2022-latest) but 2019-latest is used in Lombiq.GitHub.Actions #637

Merged
merged 38 commits into from
Dec 31, 2023

Conversation

Psichorex
Copy link
Contributor

@Psichorex Psichorex commented Dec 5, 2023

@Psichorex Psichorex changed the title Updating LGHA. OSOE-481: Action pulls latest SQL Server (=2022-latest) but 2019-latest is used in Lombiq.GitHub.Actions Dec 5, 2023
@github-actions github-actions bot changed the title OSOE-481: Action pulls latest SQL Server (=2022-latest) but 2019-latest is used in Lombiq.GitHub.Actions OSOE-481: Updating LGHA. Dec 5, 2023
@Psichorex Psichorex changed the title OSOE-481: Updating LGHA. OSOE-481: Action pulls latest SQL Server (=2022-latest) but 2019-latest is used in Lombiq.GitHub.Actions Dec 5, 2023
@Psichorex
Copy link
Contributor Author

Psichorex commented Dec 5, 2023

@Piedone A UI test is failing most probably because the docker now pulls and uses sql-server-2022 but
https://github.com/Lombiq/UI-Testing-Toolbox/blob/88ec8caf6940e7f1445fe4993701fc0ce5ce5e48/Lombiq.Tests.UI/Services/SqlServerManager.cs#L173
This line receives sql2019 as a container name
This is coming from the error message of the failed docker command from Cli.Wrap()
Command: docker cp sql2019:/data/Snapshots/Database.bak /home/runner/actions-runner/_work/Open-Source-Orchard-Core-Extensions/Open-Source-Orchard-Core-Extensions/test/Lombiq.UITestingToolbox/Lombiq.Tests.UI.Samples/bin/Debug/net6.0/Temp/SetupSnapshot/SqlServer-57163436/Database.bak
Do you know maybe where it is exactly set what is the docker image name that the linux env will use? Because I wasn't able to find it yet.

@Piedone
Copy link
Member

Piedone commented Dec 5, 2023

I don't know from the top of my head, I'd need to run it with the debugger and figure out from the call stack too.

Copy link

github-actions bot commented Dec 5, 2023

This pull request has merge conflicts. Please resolve those before requesting a review.

Copy link
Member

@dministro dministro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge from dev

Copy link

This pull request has merge conflicts. Please resolve those before requesting a review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

There is nothing to compare so this is probably a bug. This repo is no branch in my Git Extensions so I didn't touch it.

Copy link
Member

@dministro dministro Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Psichorex Then, please insert the link - where you reported/found this bug - here. Or revert.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dministro The dev checkout fall behind on my branch most probably due to a pnpm-lock file preventing the updated checkout. I checked out the latest dev in the submodule and the file change disappeared.

Updating submodule:
 - Lombiq.GitHub.Actions: fast-forward
Copy link

coderabbitai bot commented Dec 31, 2023

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit-review. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants