Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-481: Action pulls latest SQL Server (=2022-latest) but 2019-latest is used in Lombiq.GitHub.Actions #637

Merged
merged 38 commits into from
Dec 31, 2023
Merged

OSOE-481: Action pulls latest SQL Server (=2022-latest) but 2019-latest is used in Lombiq.GitHub.Actions #637

Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
f3123e6
Updating LGHA.
Psichorex Dec 5, 2023
1d610c9
Updating branch references.
Psichorex Dec 5, 2023
5a386a2
Updating LGHA.
Psichorex Dec 5, 2023
ba66f6d
Updating LGHA.
Psichorex Dec 5, 2023
2593a66
Merge remote-tracking branch 'origin/dev' into issue/OSOE-481
Psichorex Dec 5, 2023
2e12ec0
Merging dev in LGHA.
Psichorex Dec 7, 2023
1534b05
Merge remote-tracking branch 'origin/dev' into issue/OSOE-481
Psichorex Dec 7, 2023
b88ab3a
Drying script.
Psichorex Dec 7, 2023
4232a69
Using sqlserver2022 directly.
Psichorex Dec 7, 2023
0663a40
Dry and renaming.
Psichorex Dec 7, 2023
8ca6de5
Using single quotes.
Psichorex Dec 7, 2023
b58142c
Using param.
Psichorex Dec 8, 2023
e0172b8
Merge branch 'dev' of https://github.com/Lombiq/Open-Source-Orchard-C…
dministro Dec 10, 2023
391cc86
Targeting issue branch in windows workflow
dministro Dec 10, 2023
0a21d64
Updating references.
Psichorex Dec 11, 2023
0df7660
Merge branch 'issue/OSOE-481' of https://github.com/Lombiq/Open-Sourc…
Psichorex Dec 11, 2023
8956bcc
Fixing typo.
Psichorex Dec 11, 2023
d81de70
Testing.
Psichorex Dec 11, 2023
084d5cd
Updating submodule LGHA.Lombiq.GitHub.Actions
Psichorex Dec 15, 2023
2e1d689
Dev checkout in Lombiq.BaseTheme.
Psichorex Dec 15, 2023
68bad2e
Merge remote-tracking branch 'origin/dev' into issue/OSOE-481
Psichorex Dec 15, 2023
e724520
Merge remote-tracking branch 'origin/dev' into issue/OSOE-481
Psichorex Dec 16, 2023
6535e6a
Using var and version.
Psichorex Dec 16, 2023
4bd875b
Using exact version number as it is mandatory.
Psichorex Dec 16, 2023
7e65184
Using param.
Psichorex Dec 16, 2023
ad87024
Fix typo.
Psichorex Dec 16, 2023
6ef82e2
Trying SQL2022DEVELOPER again.
Psichorex Dec 19, 2023
0284790
Removing temp var.
Psichorex Dec 19, 2023
2751957
Using local instead of MSSQLSERVER.
Psichorex Dec 19, 2023
70b989a
Using MSSQLServer.
Psichorex Dec 19, 2023
afc2607
Testing.
Psichorex Dec 19, 2023
d376bfb
Reverting to SQL express.
Psichorex Dec 19, 2023
4617b51
Trying . as server name.
Psichorex Dec 19, 2023
f3a1b74
Merge remote-tracking branch 'origin/dev' into issue/OSOE-481
Psichorex Dec 20, 2023
04c7e13
Using var.
Psichorex Dec 20, 2023
620e7ca
Merge remote-tracking branch 'origin/dev' into issue/OSOE-481
Psichorex Dec 23, 2023
41d5283
Checking out latest dev.
Psichorex Dec 23, 2023
8a21d69
Referencing dev in workflows
dministro Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-and-test-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
if: github.ref_name != github.event.repository.default_branch &&
(github.event_name == 'workflow_dispatch' || github.event.label.name == 'run-windows-build')
name: Build and Test Windows - root solution (larger runners)
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@issue/OSOE-481
with:
parent-job-name: "root-solution-larger-runners"
machine-types: "['gitrunners-windows-2022-x64-8vcpu']"
Expand All @@ -51,7 +51,7 @@ jobs:
# Since dev builds are not awaited by anyone, they can run on the slower free runners.
if: github.ref_name == github.event.repository.default_branch
name: Build and Test Windows - root solution (standard runners)
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@issue/OSOE-481
with:
parent-job-name: "root-solution-standard-runners"
machine-types: "['windows-2022']"
Expand All @@ -69,7 +69,7 @@ jobs:
github.event_name == 'workflow_dispatch' ||
github.event.label.name == 'run-windows-build'
name: Build and Test Windows - NuGetTest solution
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@issue/OSOE-481
with:
parent-job-name: "nuget-solution"
machine-types: "['windows-2022']"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
build-and-test-larger-runners:
if: github.ref_name != github.event.repository.default_branch
name: Build and Test - root solution (larger runners)
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@issue/OSOE-481
with:
parent-job-name: "root-solution-larger-runners"
machine-types: "['buildjet-4vcpu-ubuntu-2204']"
Expand All @@ -28,7 +28,7 @@ jobs:
# Since dev builds are not awaited by anyone, they can run on the slower free runners.
if: github.ref_name == github.event.repository.default_branch
name: Build and Test - root solution (standard runners)
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@issue/OSOE-481
with:
parent-job-name: "root-solution-standard-runners"
timeout-minutes: 40
Expand All @@ -39,7 +39,7 @@ jobs:

build-and-test-nuget-test:
name: Build and Test - NuGetTest solution
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@dev
uses: Lombiq/GitHub-Actions/.github/workflows/build-and-test-orchard-core.yml@issue/OSOE-481
with:
parent-job-name: "nuget-solution"
build-directory: NuGetTest
Expand Down
2 changes: 1 addition & 1 deletion tools/Lombiq.Analyzers.PowerShell
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

There is nothing to compare so this is probably a bug. This repo is no branch in my Git Extensions so I didn't touch it.

Copy link
Member

@dministro dministro Dec 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Psichorex Then, please insert the link - where you reported/found this bug - here. Or revert.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dministro The dev checkout fall behind on my branch most probably due to a pnpm-lock file preventing the updated checkout. I checked out the latest dev in the submodule and the file change disappeared.

Submodule Lombiq.Analyzers.PowerShell updated 1 files
+3 −4 .github/workflows/static-code-analysis.yml
2 changes: 1 addition & 1 deletion tools/Lombiq.GitHub.Actions
Open in desktop
Submodule Lombiq.GitHub.Actions updated 6 files
+12 −5 .github/actions/setup-sql-server/Initialize-SqlServer.ps1
+1 −1 .github/actions/setup-sql-server/Wait-SqlServer.ps1
+2 −2 .github/actions/test-dotnet/Invoke-SolutionTests.ps1
+1 −1 .github/workflows/build-and-test-dotnet.yml
+2 −2 .github/workflows/build-and-test-orchard-core.yml
+1 −1 .github/workflows/msbuild-and-test.yml
Loading