Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: move console ui to libtrx #267

Merged
merged 7 commits into from
Sep 26, 2024
Merged

ui: move console ui to libtrx #267

merged 7 commits into from
Sep 26, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Sep 25, 2024

@rr- rr- requested review from a team as code owners September 25, 2024 20:16
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team September 25, 2024 20:16
@rr- rr- added this to the 0.4 milestone Sep 25, 2024
@rr- rr- added the Internal The invisible stuff label Sep 25, 2024
@rr- rr- self-assigned this Sep 25, 2024
@rr- rr- linked an issue Sep 25, 2024 that may be closed by this pull request
@rr- rr- requested review from aredfan and lahm86 September 26, 2024 15:14
@aredfan
Copy link

aredfan commented Sep 26, 2024

@rr- I found a new issue that wasn't introduced in this PR - if you open the dev console during cutscenes then the game crashes.

This bug is also present in the latest dev snapshot but not 0.3.

Copy link

@aredfan aredfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@rr- rr- merged commit 652745b into develop Sep 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal The invisible stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move console code to libtrx
4 participants