feat: upgrade thorvg v1.0-pre8 #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Breaking changes in the new version |
|
update thorvg version to 1.0-pre1 in Conan registry |
theashraf
changed the title
theashraf
force-pushed
the
chore/thorvg-1.0-pre1
branch
2 times, most recently
from
aa24c96 to
bdac0e2
Compare
theashraf
added
build:wasm
build:apple
build:android
enhancement
theashraf
changed the title
|
thorvg v1 rendering regression issue -> thorvg/thorvg#3039 |
- Update the build workflow to include pull request labeled events for triggering builds. - Refactor the concurrency group to include the target or label name in the group name. - Update the build-apple job to include the 'build:apple' label as a trigger condition. - Update the build-android job to include the 'build:android' label as a trigger condition. - Update the build-wasm job to include the 'build:wasm' label as a trigger condition. chore: Update Makefile - Add the '-Dengines=sw' flag to the meson setup to enable the software rendering engine. chore: Update dotlottie-ffi dependencies - Update the version of dotlottie-ffi to '0.1.31' in the Cargo.toml file. chore: Update dotlottie-ffi Cargo.wasm.toml - Remove the 'codegen-units' and 'strip' options from the Cargo.wasm.toml file. chore: Update dotlottie-rs dependencies - Update the version of thiserror to '2.0.4' in the Cargo.toml file. chore: Update dotlottie-rs build.rs - Update the bindgen version to '0.71.0' in the build.rs file. chore: Update dotlottie-rs lottie_renderer/mod.rs - Update the serde_json version to '1.0.133' in the mod.rs file. chore: Update dotlottie-rs lottie_renderer/renderer.rs - Update the clear method signature in the renderer.rs file to include separate flags for clearing paints and buffers. chore: Update dotlottie-rs lottie_renderer/thorvg.rs - Update the clear method signature in the thorvg.rs file to include separate flags for clearing paints and buffers. feat: Add thorvg-v1 feature to dotlottie-rs - Add the 'thorvg-v1' feature to the dotlottie-rs Cargo.toml file. fix: Update DotLottieRuntime and DotLottiePlayerContainer - Update the new method signatures in the DotLottieRuntime and DotLottiePlayerContainer structs to include conditional compilation based on the 'thorvg-v0' and 'thorvg-v1' features. fix: Update DotLottiePlayer - Update the new method signature in the DotLottiePlayer struct to include conditional compilation based on the 'thorvg-v0' and 'thorvg-v1' features. fix: Update LottieRendererImpl - Update the render method in the LottieRendererImpl struct to include conditional compilation based on the 'thorvg-v1' feature. fix: Update TvgRenderer - Update the clear method in the TvgRenderer struct to include conditional compilation based on the 'thorvg-v1' feature. docs: Update README.md - Update the README.md file to reflect the recent changes.
Update the clippy command in the Makefile to use the --no-default-features flag and add the thorvg-v1 feature. Also, update the build workflow to remove the --all-features flag when running cargo clippy for dotlottie-rs and dotlottie-ffi.
theashraf
force-pushed
the
chore/thorvg-1.0-pre1
branch
from
88bf479 to
2158fd6
Compare
theashraf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Feature Flags for
thorvgVersionsthorvg-v1andthorvg-v0.thorvgv0.x.x, as binaries for Linux, Windows, and macOS from the Conan registry currently only support v0.thorvg-v1is a pre-release version and is not yet stable or available on Conan.Default Configuration
thorvg-v0flag is enabled for the FFI, unless explicitly specified otherwise.Build Target Differences
thorvg-v1.WASM build -> https://github.com/LottieFiles/dotlottie-rs/actions/runs/12251496921
Apple build -> https://github.com/LottieFiles/dotlottie-rs/actions/runs/12251496917
Android build -> https://github.com/LottieFiles/dotlottie-rs/actions/runs/12251496922