Fix chrome console errors about bad label elements #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome now complains about label elements with missing or incorrect "for" attributes. See issue #505. I found four <label> elements in chm.html that were semantically labels, but not labels in the strict HTML sense as referring to a specific form input element. I changed them to plain <span> elements. Since we weren't formatted them any differently from plain elements, I didn't add a class field that we could use as a css selector in the future. I could easily be convinced to add one.
jmelott
approved these changes
Jun 14, 2024
marohrdanz
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome now complains about label elements with missing or incorrect "for" attributes. See issue #505.
I found four <label> elements in chm.html that were semantically labels, but not labels in the strict HTML sense as referring to a specific form input element.
I changed them to plain <span> elements. Since we weren't formatted them any differently from plain elements, I didn't add a class field that we could use as a css selector in the future. I could easily be convinced to add one.