Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openmmdl as MDAKit #161
Add openmmdl as MDAKit #161
Changes from 27 commits
83b080e
75cfc1c
62c0bdc
ae3a7d1
0256672
08899dc
82e7c1f
9440007
20476de
9216278
c544863
605281d
f966eaa
e8d07c8
6b19417
b7d20c0
859d1ab
ae49e9b
bcdf994
1410d2a
be7d931
9d42819
8de646d
f5d094a
a08dc0e
2835e48
f51e90e
e711476
6a67064
2b1594a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mdanalysis may not be necessary because I think we install it ourselves — but I doubt it hurts.
Do you have any specific recommendations @IAlibay @fiona-naughton @lilyminium ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also a similar case is for
versioningit
andsetuptools
which I have in thepyproject.toml
so they are installed there in theory, but I thought if I list the remaining packages I can also add them in themamba install
step so that all of the packages necessary for the package are presentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will keep for now the
mdanalysis>=2.3.0
to see what the others say if it should be removed or retained :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to have MDAnalysis here, in the end this will go in the docs as "this is how you install this".
I have moved pytest things into test_dependencies though, because as far as I'm aware they aren't necessary for the standard operations of the code.