Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Suggestions #60

Open
20 of 33 tasks
Lucas-Mc opened this issue Sep 8, 2020 · 0 comments
Open
20 of 33 tasks

Website Suggestions #60

Lucas-Mc opened this issue Sep 8, 2020 · 0 comments

Comments

@Lucas-Mc
Copy link
Collaborator

Lucas-Mc commented Sep 8, 2020

When the browser window is narrowed considerably, or when the display is scaled up or down (command+- or command+= on a mac), some strange or unfortunate things happen

  • header logo shouldn't scale up and down. It and the header Laboratory for Computational Physiology should retain same relative sizes. Alignment of logo and header should be massaged so they maintain pleasing relationship. It might be a good idea to float both logo and header left, so they act as a unit.

  • I like seeing the logo as being inside a padded box with background color rgm(223,232,245) as on the old site. I can make a new version of the image file with background included, if that's easier to use.

  • background gradient of homepage image should be tweaked so it starts with the same as color of lcp logo. Right now its looks slightly off. Set it to linear-gradient (rgb(68, 102, 170) 50%, rgb(0, 0, 0))? rather than using rgba? Or can you start at rgba(68, 102, 170, 1.0)?

  • footer logos shouldn't scale, and it might be good to provide text adjacent to the logos explaining what they signify. Also, alt text should say, e.g., MIT logo, not MIT photo logo. Size/scale and alignment of logos should be adjusted. http://imes.mit.edu/ and https://hst.mit.edu/ both show text with logo. We should look at graphics standards on these sites (or elsewhere) to make sure we're using the logo (and associated text) correctly.

  • font-family on page is Playfair Display, Georgia, Times New Roman, serif. I think Playfair Display is ugly. I'd just use Georgia, Times, serif. (Times New Roman isn't really a complete font....)

  • font in footer headers is weight 700, too bold. Should be 500 to match other headers on the page.

  • links in footer, and probably all links on the page, should be set to target="_blank". Either that, or we should provide breadcrumbs, though I don't much like those.

  • same thing for continue reading... links. (Also, I basically dislike continue reading... links. They're fine if you're presenting clickbait, or if there really is a vast amount of content. Otherwise, just put the text on the page so the user can see it and maybe skim it or just scroll past it. My bias may be because I don't use a cell phone for web browsing....)

  • In the following text:

<p>The Laboratory for Computational Physiology (LCP), under the direction of Professor Roger Mark, conducts research on improving health care through new and refined approaches to interpreting data. Some of the group’s researchers have medical backgrounds; others have backgrounds in computer science, electrical engineering, physics, or mathematics; and others have training that spans several of these disciplines. Current laboratory research incorporates physiology, computer science, engineering, and applied mathematics. <br><br> Using modern approaches to modeling, signal processing, pattern recognition, and machine learning, the lab’s researchers develop and refine methods for analyzing data—for example, from patients in intensive care units—and for generating predictive models that will aid in patient care. Current laboratory research comprises two major projects, the <a href="mimic">MIMIC</a> project and <a href="physionet">PhysioNet</a>. See their respective pages for more detailed information. </p>

and maybe elsewhere <br><br> should be replaced by </p><p>. There are two paragraphs in the passage.

  • on the .../about page, header spacing is strange. Prabably should increase padding-top for h2. Maybe adjust font sizes for h1, h2, etc.

  • I think the contact address should be mailing address, 77 Massachusetts Ave. Street address is for couriers or in-person visits -- we can provide it privately as needed.

  • scaling the page (command+- or command+=) probably shouldn't affect width of displayed text. That is, we should allow the user to scale the text down without also squeezing it into a narrow column. The old (blue) lcp site has this problem too. The current physionet site does not -- hitting command+- repeatedly still gives a full-width page.

  • navbar should wrap in a narrow browser window. Right now, overflow is off the screen and unreachable. This is a showstopper, though admittedly the problem is only there in relatively extreme circumstances.

  • .col-md-3 should scale differently. It can be set to 25%, but also give it a min-width so it won't squash past a certain point.

  • I have only once had to grapple with bootstrap css. Good news is that it's meant to cover all cases. Bad news is that it's really hard to figure out what's going on sometimes, and how to make adjustments.

  • header hierarchy on People page seems wrong. Individual names should probably be h3. Header font sizes and padding should be adjusted. (On old (blue) lcp site, I used a dl for names and bios. I think this is clearer structurally.)

  • alt tags for images on People page should say, e.g., photo of Roger Mark rather than just Roger Mark.

  • I think a search form would be useful. (not Google due to the ads!!)

  • more about the footer: I'm not sure we should include recent publications. Folks who want publications can click the tab up above. In any case, the read more... link is superfluous. The quick links should probably include some sort of explanatory text: most are subprojects of the lcp, though I'm not sure about Sana. Accessibility is there because it has to be. All of the links lead away from the lcp site.

  • we should provide Skip to content links as on the old (blue) site, for those using lynx or screen readers.


  • continue reading for the news items should be expanded inside of the news box (or have a scroll bar)

  • the sidebars with internal links need a minimum width to be set

  • the top navbar should be justified to the left to prevent spaced apart items

  • there is an extra </head> tag from the skip-to-content addition, move skip-to-content to just before the first LCP header

  • remove the map


  • Change address to E25-505

  • Change News to Announcements

  • Remove recent publications in footer / Emphasize recent publications -> quick links

  • Move content from current website

  • Add links to PhysioNet and MIMIC in the text

  • Move quick links from footer to top of each page

  • Remove Sana and Critical Data / add Consortium, Courses, Datathons, Educational, etc.

  • New tab with other links with description

Lucas-Mc added a commit that referenced this issue Sep 8, 2020
Fixes the image background gradient on the home page to more resemble the color of the logo in the top left corner. Fixes part of #60.
tompollard added a commit that referenced this issue Sep 8, 2020
Fixes image background gradient #60
Lucas-Mc added a commit that referenced this issue Sep 8, 2020
Adds a background to the LCP logo on the main page. This revives the appearance of the logo on the old website. Also fixes the image size to maintain size during adjustment of the window. Fixes part of #60.
Lucas-Mc added a commit that referenced this issue Sep 8, 2020
Changes the address used to contact the lab from the private address to the public MIT mailing address. Fixes part of #60.
tompollard added a commit that referenced this issue Sep 8, 2020
Lucas-Mc added a commit that referenced this issue Sep 8, 2020
Fixes the research summary paragraph on the main page to split multiple paragraphes by <p> tags instead of <br> tags. Fixes part of #60.
Lucas-Mc added a commit that referenced this issue Sep 8, 2020
Lucas-Mc added a commit that referenced this issue Sep 8, 2020
Reduces the font-weight of the titles in the footer from 700 to 500 to match the other headers. Fixes part of #60.
tompollard added a commit that referenced this issue Sep 8, 2020
Fixes main page intro paragraph #60
tompollard added a commit that referenced this issue Sep 8, 2020
Reduces footer title boldness #60
Lucas-Mc added a commit that referenced this issue Sep 8, 2020
Changes some links to open in a new tab. Specifically, the links in the footer and the continue reading links were changed. Direct links to other pages in the navbar are unchanged. Fixes part of #60.
Lucas-Mc added a commit that referenced this issue Sep 8, 2020
Changes font style by removing Playfair Display from the font family. This increases the readability of the text. Fixes part of #60.
tompollard added a commit that referenced this issue Sep 8, 2020
Makes some links open in new tabs #60
Lucas-Mc added a commit that referenced this issue Sep 9, 2020
Changes the photos on the People Page to include a more descriptive alt tag: Roger Mark to photo of Roger Mark. Also changes photo id to be more descriptive: Roger_Mark to photo_of_Roger_Mark. Fixes part of #60.
Lucas-Mc added a commit that referenced this issue Sep 9, 2020
Fixes the h2 tag of the lab members name to an h3 tag to stay consistent with the rest of the header tags. Fixes part of #60.
tompollard added a commit that referenced this issue Sep 9, 2020
Fixes People Page header ordering #60.
Lucas-Mc added a commit that referenced this issue Sep 9, 2020
Changes the photos on the People Page to include a more descriptive alt tag: Roger Mark to photo of Roger Mark. Also changes photo id to be more descriptive: Roger_Mark to photo_of_Roger_Mark. Fixes part of #60.

Changes photo alt tag
Lucas-Mc added a commit that referenced this issue Sep 9, 2020
Adds links at the top of each page to skip users directly to the content. This is useful for those using Lynx and Screen Readers as mentioned in #60. Fixes part of #60.
Lucas-Mc added a commit that referenced this issue Sep 9, 2020
Adds links at the top of each page to skip users directly to the content. This is useful for those using Lynx and Screen Readers as mentioned in #60. Fixes part of #60.

Fixes link readability error
Lucas-Mc added a commit that referenced this issue Sep 9, 2020
Changes the photos on the People Page to include a more descriptive alt tag: Roger Mark to photo of Roger Mark. Also changes photo id to be more descriptive: Roger_Mark to photo_of_Roger_Mark. Fixes part of #60.

Changes photo alt tag

Returns old style

Fixes People Page header ordering #60.

Fixes the h2 tag of the lab members name to an h3 tag to stay consistent with the rest of the header tags. Fixes part of #60.
Lucas-Mc added a commit that referenced this issue Sep 9, 2020
Changes the photos on the People Page to include a more descriptive alt tag: Roger Mark to photo of Roger Mark. Also changes photo id to be more descriptive: Roger_Mark to photo_of_Roger_Mark. Fixes part of #60.

Changes photo alt tag

Returns old style

Fixes People Page header ordering #60.

Fixes the h2 tag of the lab members name to an h3 tag to stay consistent with the rest of the header tags. Fixes part of #60.

Fixes typo
Lucas-Mc added a commit that referenced this issue Sep 9, 2020
Changes the photos on the People Page to include a more descriptive alt tag: Roger Mark to photo of Roger Mark. Also changes photo id to be more descriptive: Roger_Mark to photo_of_Roger_Mark. Fixes part of #60.

Changes photo alt tag

Returns old style

Fixes People Page header ordering #60.

Fixes the h2 tag of the lab members name to an h3 tag to stay consistent with the rest of the header tags. Fixes part of #60.

Fixes typo

Fixes typo
tompollard added a commit that referenced this issue Sep 9, 2020
People Page: change photo alt and id #60
Lucas-Mc added a commit that referenced this issue Sep 9, 2020
Adds links at the top of each page to skip users directly to the content. This is useful for those using Lynx and Screen Readers as mentioned in #60. Fixes part of #60.

Fixes link readability error

Adds CSS to stylesheet
tompollard added a commit that referenced this issue Sep 9, 2020
Lucas-Mc added a commit that referenced this issue Sep 9, 2020
Modifies the top navbar so that it wraps when the window width is decreased significantly. Fixes part of #60.
tompollard added a commit that referenced this issue Sep 9, 2020
Lucas-Mc added a commit that referenced this issue Sep 10, 2020
Fixes the sidebar being squashed when the window width is reduced. Previously, the sidebar would compress to a very small width which would not go away even if it wrapped to a new line. Now, the sidebar keeps a minimum width of 150px while expanding if wrapped to a new line. Fixes part of #60.
Lucas-Mc added a commit that referenced this issue Sep 10, 2020
Fixes the error where the skip-to-content link was inserted before the valid HTML began which cause W3C errors. Now, the link is inserted immeditally after the start of the body tag. Fixes part of #60.
Lucas-Mc added a commit that referenced this issue Sep 10, 2020
Removes the map from the About page and also all other related script and HTML files. Fixes part of #60.
elfeto added a commit that referenced this issue Sep 10, 2020
elfeto added a commit that referenced this issue Sep 10, 2020
Fixes skip-to-content error #60
elfeto added a commit that referenced this issue Sep 10, 2020
Lucas-Mc added a commit that referenced this issue Sep 10, 2020
Adds scrolling functionality to the front page news items. Links to the news page are removed since they did not lead to the correct page. News box items are set to a rigid height and the inside text is set to scroll if needed while keeping content such as the title and date static. Fixes part of #60.
tompollard added a commit that referenced this issue Sep 11, 2020
Generates new page for each news item #60
Lucas-Mc added a commit that referenced this issue Sep 17, 2020
Adds E25-505 to address to specify the LCP. Fixes part of #60.
Lucas-Mc added a commit that referenced this issue Sep 17, 2020
Adds links to PhysioNet and MIMIC on their respective pages. Fixes part of #60.
tompollard added a commit that referenced this issue Sep 23, 2020
Lucas-Mc added a commit that referenced this issue Sep 23, 2020
Adds links to PhysioNet and MIMIC on their respective pages. Fixes part of #60.

Removes extra list tag
elfeto added a commit that referenced this issue Sep 23, 2020
Adds PhysioNet and MIMIC links #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant