Converted mutable matrices to matrices in instances of sub()
#2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point M2 no longer allowed for mutable matrices to be used in `sub()`. Instances of this was fixed by converting the mutable matrices to a matrix.
|
I forgot to mention, this is an update for |
|
@mikestillman @DanGrayson this PR seems to have been merged into master only, hence the commit isn't present in development, which may be contributing to merging issues in other pull requests. |
|
Was this a mistake on my part? Should I be making the PRs to a development branch instead? |
|
You should make PRs to development branch, but before merging maintainers can also switch the base branch if it's not correct, but that wasn't noticed in this case. I don't think you have to do anything else now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point M2 no longer allowed for mutable matrices to be used in
sub(). Instances of this was fixed by converting the mutable matrices to a matrix.