Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted mutable matrices to matrices in instances of sub() #2892

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Converted mutable matrices to matrices in instances of sub() #2892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions M2/Macaulay2/packages/QuillenSuslin.m2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ newPackage(
Date => "May 10, 2013",
Authors => {
{Name => "Brett Barwick", Email => "[email protected]", HomePage => "http://faculty.uscupstate.edu/bbarwick/"},
{Name => "Branden Stone", Email => "bstone@adelphi.edu", HomePage => "http://math.adelphi.edu/~bstone/"}
{Name => "Branden Stone", Email => "[email protected].edu", HomePage => "http://bstone.github.io/"}
},
Headline => "the Quillen-Suslin algorithm for bases of projective modules",
Keywords => {"Commutative Algebra"},
Expand Down Expand Up @@ -1457,7 +1457,7 @@ monicPolySubs(RingElement,List) := opts -> (f,varList) -> (
print "The element had degree zero in the last variable.";
degZeroSub = mutableMatrix vars R;
degZeroSub = columnSwap(degZeroSub,last usedVarPosition,lastVarPosition);
f = sub(f,degZeroSub); -- Interchange variables so that last varList is involved in f. Now f has positive degree in last varList.
f = sub(f,matrix degZeroSub); -- Interchange variables so that last varList is involved in f. Now f has positive degree in last varList.
);

-- Now we enter the general algorithm.
Expand Down Expand Up @@ -1495,7 +1495,7 @@ monicPolySubs(RingElement,List) := opts -> (f,varList) -> (
if degZeroSub =!= null then (
print("degZeroSub: "|toString(degZeroSub));
tempSub = columnSwap(tempSub,last usedVarPosition,lastVarPosition);
tempInvSub = sub(tempInvSub,degZeroSub);
tempInvSub = sub(matrix tempInvSub,matrix degZeroSub);
);

return (matrix tempSub,matrix tempInvSub);
Expand Down