Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various output routine updates #3260

Merged
merged 3 commits into from
May 27, 2024
Merged

Various output routine updates #3260

merged 3 commits into from
May 27, 2024

Conversation

pzinn
Copy link
Contributor

@pzinn pzinn commented May 24, 2024

  • moved some TeX-related code from expressions.m2 to latex.m2
  • fixed an annoying double superscript bug for things like x'_1^2
  • harmonised tex output of zero vectors
  • added ReverseDictionary to iterators
  • added texMath RRi

mahrud
mahrud reviewed May 24, 2024
View reviewed changes
M2/Macaulay2/m2/latex.m2 Outdated Show resolved Hide resolved
mahrud
mahrud reviewed May 24, 2024
View reviewed changes
M2/Macaulay2/m2/latex.m2 Outdated Show resolved Hide resolved
@pzinn
Copy link
Contributor Author

pzinn commented May 24, 2024

those inter-dependencies of various files in the loadsequence are a pain

@pzinn
Copy link
Contributor Author

pzinn commented May 24, 2024

so with this PR: iterators.m2 needs expressions.m2 which needs max.m2 which needs fold.m2 which needs iterators.m2...
how are we supposed to deal with those circular dependencies?

@d-torrance
Copy link
Member

I suppose the accumulate and fold methods involving Thing (i.e., the ones that use iterators) could get moved from fold.m2 to iterators.m2 to remove that dependency.

@DanGrayson
Copy link
Member

Could you fix the broken test-builds, please?

@pzinn
Copy link
Contributor Author

pzinn commented May 27, 2024

a NumericalImplicitization test runs oom, don't think it's related to this PR?

@d-torrance
Copy link
Member

a NumericalImplicitization test runs oom, don't think it's related to this PR?

Probably #3239

@mahrud
Copy link
Member

mahrud commented May 27, 2024

I reran that test and it passed; LGTM!

@DanGrayson DanGrayson merged commit aa1cd3a into Macaulay2:development May 27, 2024
6 checks passed
pzinn added a commit to pzinn/M2 that referenced this pull request May 29, 2024
@pzinn
fix Macaulay2#3260
51e2c07
@pzinn pzinn mentioned this pull request May 29, 2024
Merged
DanGrayson added a commit that referenced this pull request Jun 5, 2024
@DanGrayson
Merge pull request #3267 from pzinn/main
571ee97 
fix #3260
antonleykin pushed a commit to antonleykin/M2 that referenced this pull request Jul 2, 2024
@pzinn
fix Macaulay2#3260
650c705
Devlin-Mallory pushed a commit to Devlin-Mallory/M2 that referenced this pull request Aug 30, 2024
@pzinn @Devlin-Mallory
fix Macaulay2#3260
692a1f6
mgacummings pushed a commit to mgacummings/M2 that referenced this pull request Oct 19, 2024
@pzinn @mgacummings
fix Macaulay2#3260
28594c7
mgacummings pushed a commit to mgacummings/M2 that referenced this pull request Oct 21, 2024
@pzinn @mgacummings
fix Macaulay2#3260
9897c48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahrud mahrud mahrud left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pzinn @d-torrance @DanGrayson @mahrud