Add part for graded objects and other improvements
#3522
Conversation
mahrud
force-pushed
the
quickfix/part
branch
2 times, most recently
from
be82d3e
to
b1eb629
Compare
| f := truncate(degs, dd^C_lo, opts); | ||
| complex hashTable for i from lo+1 to hi list i => ( | ||
| f = inducedTruncationMap(source f, truncate(degs, C_i, opts), dd^C_i)) | ||
| )) | ||
|
|
There was a problem hiding this comment.
Can we avoid calling Truncation within part?
There was a problem hiding this comment.
We do not call truncate within part. We do however call basis.
| complex hashTable for i from lo+1 to hi list i => ( | ||
| f = inducedBasisMap(source f, image basis(deg, C_i, opts), dd^C_i)) | ||
| )) | ||
|
|
There was a problem hiding this comment.
The phrase basis of complex seems particularly unfortunate.
Tests have been included, I'm happy to add some documentation this week if otherwise the changes are acceptable.
I'm happy to remove Alternatively, would it make sense to have an internal method for |
|
I removed cover, super, ambient, and changed part to use an unexported |
|
I also changed this PR to only depend on 4 specific commits from the basis PR, which in particular don't include any breaking change. |
This PR is on top of #3519.
Summary of changes:
part(ZZ, Complex), but for other graded objectspart(ZZ, Complex), but the base ring is the original ring, not its coefficient ringcoverhere was so I could make this simplificationThe rest are optimizations in line with #3352 to eliminate unnecessary gb computations, though there's more work left.