Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling conflicts again #2

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
5d12f4d
Add leaks and vunerability checks
arran4 Sep 9, 2022
2c93a04
Requires secrets now
arran4 Sep 9, 2022
cb34d82
Renamed interface as it's useful own it's own. Made it public. Added …
arran4 Nov 6, 2022
320d5fd
fix: omit zone in "AllDay" event helpers
dnwe Apr 5, 2023
d60522a
calendar parsing url support
Courtcircuits Sep 23, 2023
dadd290
usage example, README
Courtcircuits Sep 23, 2023
6d9f344
added functionnal option pattern for url parsing
Courtcircuits Oct 24, 2023
eca14a4
Should be able to distinguish unset from invalid time properties
brackendawson Sep 22, 2024
4251b08
Improve error for property not found
brackendawson Sep 25, 2024
ed74932
Remove deprecated ioutil
brackendawson Sep 25, 2024
efc12a1
Move targeted Go version to 1.20
brackendawson Sep 26, 2024
229e6a3
Merge pull request #98 from brackendawson/time-prop-err
arran4 Sep 26, 2024
e9a75cb
Add method to remove property
quite Aug 22, 2024
f364b80
Merge pull request #96 from quite/removeproperty
arran4 Sep 28, 2024
34998ad
Merge branch 'master' into pimtrace_changes
arran4 Sep 28, 2024
1c96d16
Merged
arran4 Sep 28, 2024
4e7b969
Merge pull request #59 from arran4/pimtrace_changes
arran4 Sep 28, 2024
ed4039d
Merge branch 'master' into govun
arran4 Sep 28, 2024
18b0c81
New tool
arran4 Sep 28, 2024
c9951e3
Merge pull request #58 from arran4/govun
arran4 Sep 28, 2024
0c815e1
Merge branch 'master' into fix-allday-events
arran4 Sep 28, 2024
284ee76
Reintegration of https://github.com/arran4/golang-ical/pull/67
arran4 Sep 28, 2024
56133a5
Merge branch 'master' into URL-support-for-parsing-78
arran4 Sep 28, 2024
59af956
Resynced and moved some functions around https://github.com/arran4/go…
arran4 Sep 28, 2024
3719f65
Test fixed.
arran4 Sep 28, 2024
dc27620
Merge pull request #101 from arran4/fix-allday-events
arran4 Sep 29, 2024
19c2af0
Create bug.md
arran4 Sep 29, 2024
adbe036
Create other.md
arran4 Sep 29, 2024
5d75843
Create default.md
arran4 Sep 29, 2024
2754527
Rename default.md to pull_request_template.md
arran4 Sep 29, 2024
a707608
Minor update
arran4 Sep 29, 2024
da97ef3
refactor: remove unnecessary named return values, harmonizing code base
quite Sep 29, 2024
2a553d0
Merge pull request #103 from quite/ditch-named-return-values
arran4 Sep 30, 2024
b119f91
refactor: rename var to reflect what it is
quite Sep 30, 2024
4872343
Merge pull request #104 from quite/rename-var
arran4 Sep 30, 2024
f3983af
refactor: use ReplaceAll
quite Sep 30, 2024
3111023
refactor: prefer switch for readability
quite Sep 30, 2024
64998cf
refactor: use consistent receiver names
quite Sep 30, 2024
176f16f
refactor: rename unused arg as '_'
quite Sep 30, 2024
937429d
Merge pull request #105 from quite/readability-nits
arran4 Oct 1, 2024
7fc77bd
Tests added.
arran4 Oct 15, 2024
5274eb1
Some larger upgrades.
arran4 Oct 15, 2024
5bb438c
Fix
arran4 Oct 15, 2024
bdf47c9
Some multiple-ness.
arran4 Oct 15, 2024
da22825
Merge branch 'master' into URL-support-for-parsing-78
arran4 Oct 15, 2024
7bc0b76
Duplication issue fixed.
arran4 Oct 15, 2024
6e992ef
Merge branch 'master' into error-handling-conflicts-again
arran4 Oct 15, 2024
df1f583
Merged
arran4 Oct 15, 2024
7fb626c
Merge pull request #102 from arran4/URL-support-for-parsing-78
arran4 Oct 15, 2024
ecde28c
Merge branch 'master' into error-handling-conflicts-again
arran4 Oct 15, 2024
2467de0
Merge pull request #108 from arran4/issue89
arran4 Oct 15, 2024
1015df8
Merge remote-tracking branch 'origin/master' into issue97
arran4 Oct 16, 2024
0d0e9ff
Merge remote-tracking branch 'origin/master' into issue97
arran4 Oct 16, 2024
4b57639
Merge pull request #106 from arran4/issue97
arran4 Oct 17, 2024
f417dc8
Merge branch 'master' into error-handling-conflicts-again
arran4 Oct 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .github/ISSUE_TEMPLATE/bug.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
---
name: 🐞 Bug
about: File a bug/issue
title: '[BUG] <title>'
labels: Bug, Needs Triage
assignees: ''

---

<!--
Note: Please search to see if an issue already exists for the bug you encountered.
-->

### Current Behavior:
<!-- A concise description of what you're experiencing. -->

### Expected Behavior:
<!-- A concise description of what you expected to happen. -->

### Steps To Reproduce:
<!--
Example: steps to reproduce the behavior:
1. In this environment...
1. With this config...
1. Run '...'
1. See error...
-->

### Minimal Example ical extract:

```ical
BEGIN:VCALENDAR
....
```

### Anything else:
<!--
Links? References? Anything that will give us more context about the issue that you are encountering!
-->
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE/other.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
name: Something else
about: Any other issue
title: '<title>'
labels: Needs Triage
assignees: ''

---

<!--
Note: Please search to see if an issue already exists for the bug you encountered.

Please include smallest possible sized examples.
-->

35 changes: 35 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<!--

Thanks for contributing!

-->

# Pull Request Template

## Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

<!-- The following line will automatically close the issues if done correctly -->

Fixes # (issue)

## Type of change

Please delete options that are not relevant.

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) -- This might take a while to be considered

## Must haves:

- [ ] I have commented in hard-to-understand areas and anywhere the function not immediately apparent
- [ ] I have made corresponding changes to the comments (if any)
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove the fix is effective or that my feature works
- [ ] I have added tests that protects the code from degradation in the future

## Nice to haves:

- [ ] I have added additional function comments to new or existing functions
9 changes: 7 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,18 @@ A ICS / ICal parser and serialiser for Golang.
Because the other libraries didn't quite do what I needed.

Usage, parsing:
```
```golang
cal, err := ParseCalendar(strings.NewReader(input))

```

Creating:
Usage, parsing from a URL :
```golang
cal, err := ParseCalendar("an-ics-url")
```

Creating:
```golang
cal := ics.NewCalendar()
cal.SetMethod(ics.MethodRequest)
event := cal.AddEvent(fmt.Sprintf("id@domain", p.SessionKey.IntID()))
Expand Down
Loading
Loading