Error handling conflicts again #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a date-only event (i.e., an event that lasts for the full day) the iCalendar specification indicates that the value for DTSTART / DTEND should be a DATE https://icalendar.org/iCalendar-RFC-5545/3-6-1-event-component.html > The "VEVENT" is also the calendar component used to specify an > anniversary or daily reminder within a calendar. These events have a > DATE value type for the "DTSTART" property instead of the default value > type of DATE-TIME. If such a "VEVENT" has a "DTEND" property, it MUST be > specified as a DATE value also The DATE format (https://icalendar.org/iCalendar-RFC-5545/3-3-4-date.html) should omit both time and zone/location elements and additionally notes that "The "TZID" property parameter MUST NOT be applied to DATE properties" As per the specification, this PR also adds an explicit "VALUE=DATE" parameter when the AllDay helpers were called, to indicate that the property's default value type has been overridden and the VEVENT is intended to be an all-day event https://icalendar.org/iCalendar-RFC-5545/3-2-20-value-data-types.html Finally the SetDuration call has been updated to preserve the "AllDay" characteristics if the existing start or end has been specified in DATE format, which is also a requirement of the spec. Contributes-to: #55
Co-authored-by: Arran Ubels <[email protected]>
And test the target forever
Should be able to distinguish unset from invalid time properties
Add method to remove property
* master: (54 commits) Add method to remove property Move targeted Go version to 1.20 Remove deprecated ioutil Improve error for property not found Should be able to distinguish unset from invalid time properties Add ComponentPropertyRelatedTo; the VTODO component can have that fix: reduce build restriction on serialization test fix: add test err assertion refactor: switch syntax refactor: reduce scope of gitignore refactor: fix linting errors breaking: unescape Property.Value of type TEXT fix: VFREEBUSY serialization add: serialiation test add: stable serialization of property parameters fix: use macos-13, arm is not supported by setup-go fix: explicitly list golang versions fix: simplify & update ghas add: contributing.md Re-add Calendar.RemoveEvent method ... # Conflicts: # components.go
Renamed interface as it's useful own it's own. Made it public. Added …
* master: (56 commits) Merged Add method to remove property Move targeted Go version to 1.20 Remove deprecated ioutil Improve error for property not found Should be able to distinguish unset from invalid time properties Add ComponentPropertyRelatedTo; the VTODO component can have that fix: reduce build restriction on serialization test fix: add test err assertion refactor: switch syntax refactor: reduce scope of gitignore refactor: fix linting errors breaking: unescape Property.Value of type TEXT fix: VFREEBUSY serialization add: serialiation test add: stable serialization of property parameters fix: use macos-13, arm is not supported by setup-go fix: explicitly list golang versions fix: simplify & update ghas add: contributing.md ...
Add leaks and vunerability checks
* master: (53 commits) New tool Merged Add method to remove property Move targeted Go version to 1.20 Remove deprecated ioutil Improve error for property not found Should be able to distinguish unset from invalid time properties Add ComponentPropertyRelatedTo; the VTODO component can have that fix: reduce build restriction on serialization test fix: add test err assertion refactor: switch syntax refactor: reduce scope of gitignore refactor: fix linting errors breaking: unescape Property.Value of type TEXT fix: VFREEBUSY serialization add: serialiation test add: stable serialization of property parameters fix: use macos-13, arm is not supported by setup-go fix: explicitly list golang versions fix: simplify & update ghas ... # Conflicts: # components.go # property.go
* master: (52 commits) New tool Merged Add method to remove property Move targeted Go version to 1.20 Remove deprecated ioutil Improve error for property not found Should be able to distinguish unset from invalid time properties Add ComponentPropertyRelatedTo; the VTODO component can have that fix: reduce build restriction on serialization test fix: add test err assertion refactor: switch syntax refactor: reduce scope of gitignore refactor: fix linting errors breaking: unescape Property.Value of type TEXT fix: VFREEBUSY serialization add: serialiation test add: stable serialization of property parameters fix: use macos-13, arm is not supported by setup-go fix: explicitly list golang versions fix: simplify & update ghas ... # Conflicts: # calendar.go
Fix allday events
refactor: remove unnecessary named return values, harmonizing code base
These functions take optional variadic PropertyParam arguments, in ical speak they are not properties, but parameters for a property.
refactor: rename var to reflect what it is
refactor: fix some readability nits
* master: refactor: rename unused arg as '_' refactor: use consistent receiver names refactor: prefer switch for readability refactor: use ReplaceAll refactor: rename var to reflect what it is refactor: remove unnecessary named return values, harmonizing code base Minor update Rename default.md to pull_request_template.md Create default.md Create other.md Create bug.md Reintegration of #67 fix: omit zone in "AllDay" event helpers # Conflicts: # components.go
* master: (23 commits) refactor: rename unused arg as '_' refactor: use consistent receiver names refactor: prefer switch for readability refactor: use ReplaceAll refactor: rename var to reflect what it is refactor: remove unnecessary named return values, harmonizing code base Minor update Rename default.md to pull_request_template.md Create default.md Create other.md Create bug.md Reintegration of #67 New tool Merged Add method to remove property Move targeted Go version to 1.20 Remove deprecated ioutil Improve error for property not found Should be able to distinguish unset from invalid time properties fix: omit zone in "AllDay" event helpers ... # Conflicts: # .github/workflows/test.yml # calendar.go # components.go # components_test.go # errors.go
This was referenced Oct 15, 2024
URL-support-for-parsing-78
* master: Duplication issue fixed. Test fixed. Resynced and moved some functions around #78 added functionnal option pattern for url parsing usage example, README calendar parsing url support # Conflicts: # calendar_test.go
|
More conflicts resolved. |
Addition of some multiple Component Properties functionality and basis for later sanity checking
* origin/master: Duplication issue fixed. Some multiple-ness. Test fixed. Resynced and moved some functions around #78 added functionnal option pattern for url parsing usage example, README calendar parsing url support
* origin/master: Duplication issue fixed. Some multiple-ness. Test fixed. Resynced and moved some functions around #78 added functionnal option pattern for url parsing usage example, README calendar parsing url support # Conflicts: # calendar.go # calendar_test.go # components.go
Issue 97: Support for Alternative Representations
* master: Merge remote-tracking branch 'origin/master' into issue97 Some multiple-ness. Fix Some larger upgrades. Tests added. # Conflicts: # calendar_test.go # components.go
|
Merged! Sorry for the delay! :) |
|
All good. Let's see how we go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for:
arran4#73
However I'm getting scared of this breaking things as the code is getting pretty hard to understand what's changed as things move on.
Can you merge then we can speed through a fix this week sometime?