Merge pull request #14 from MartinuzziFrancesco/fm/rhn

Fix RHN
MartinuzziFrancesco · Dec 3, 2024 · 31fceed · 31fceed
2 parents 45d9333 + 7663a9e
commit 31fceed
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/indrnn_cell.jl b/src/indrnn_cell.jl
@@ -54,7 +54,7 @@ end
 function (indrnn::IndRNNCell)(inp::AbstractVecOrMat, state::AbstractVecOrMat)
     _size_check(indrnn, inp, 1 => size(indrnn.Wi, 2))
     σ = NNlib.fast_act(indrnn.σ, inp)
-    state = σ.(indrnn.Wi*inp .+ indrnn.u.*state .+ indrnn.b)
+    state = σ.(indrnn.Wi*inp .+ indrnn.u .* state .+ indrnn.b)
     return state
 end
 

diff --git a/src/rhn_cell.jl b/src/rhn_cell.jl
@@ -31,7 +31,7 @@ function (rhn::RHNCellUnit)(inp::AbstractVecOrMat, state)
     weight, bias = rhn.weight, rhn.bias
 
     #compute
-    pre_nonlin = weight * inp + bias
+    pre_nonlin = weight * inp .+ bias
 
     #split
     pre_h, pre_t, pre_c = chunk(pre_nonlin, 3, dims = 1)

diff --git a/test/test_cells.jl b/test/test_cells.jl
@@ -61,9 +61,9 @@ end
     @test rnncell(inp) == rnncell(inp, zeros(Float32, 5))
 
     ##TODO rhncell bias is bugged atm
-    #rnncell = RHNCell(3 => 5; bias=false)
-    #@test length(Flux.trainables(rnncell)) == 3
+    rnncell = RHNCell(3 => 5; bias=false)
+    @test length(Flux.trainables(rnncell)) == 3
 
-    #inp = rand(Float32, 3)
-    #@test rnncell(inp) == rnncell(inp, zeros(Float32, 5))
+    inp = rand(Float32, 3)
+    @test rnncell(inp) == rnncell(inp, zeros(Float32, 5))
 end