Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some test helpers to framework repository #6

Open
wants to merge 793 commits into
base: main
Choose a base branch
from

Conversation

davidhorstmann-arm
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm commented Mar 27, 2024

Move some files from tests/src and tests/include/test into the framework repo.

Synchronized with: Mbed-TLS/mbedtls#8992

silabs-Kusumit and others added 30 commits September 5, 2023 19:29
Signed-off-by: Kusumit Ghoderao <[email protected]>
No semantic change.

Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
More consistent use of mbedtls_ct_memcmp
…hort_buffer

Fix buffer overread in mbedtls_ssl_decrypt_buf with stream cipher
Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
Document driver only hashes (overdue)
…opment-restricted-merge-20230925

Conflicts:
* `include/mbedtls/build_info.h`: a new fragment to auto-enable
  `MBEDTLS_CIPHER_PADDING_PKCS7` was added in
  c9f4040 in `development-restricted`.
  In `development`, this section of the file has moved to
  `include/mbedtls/config_adjust_legacy_crypto.h`.
* `library/bignum.c`: function name change in `development-restricted` vs
  comment change in development. The comment change in `development` is not
  really relevant, so just take the line from `development-restricted`.
…CIPHER_C

A new internal function is added to get cipher's info (mode, key bits and
iv len) without relying on CIPHER_C. This function is basically a lookup
table used only for test purposes.

Signed-off-by: Valerio Setti <[email protected]>
…rms()

Use !USE_PSA_CRYPTO instead.

Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
Signed-off-by: Dave Rodgman <[email protected]>
Clean up curves handling in libtestdriver1 config
[G2] Make TLS work without Cipher
Done by commands:

```
sed -i "s/MBEDTLS_\(AES\|CAMELLIA\|ARIA\|CHACHAPOLY\)_C/MBEDTLS_SSL_HAVE_\1/g" tests/{suites,include,src}/**/*ssl*
sed -i "s/MBEDTLS_\(GCM\|CCM\)_C/MBEDTLS_SSL_HAVE_\1/g" tests/{suites,include,src}/**/*ssl*
sed -i "s/MBEDTLS_CIPHER_MODE_\(CBC\)/MBEDTLS_SSL_HAVE_\1/g" tests/{suites,include,src}/**/*ssl*
```

Signed-off-by: Pengyu Lv <[email protected]>
git revert v3.5.0..v3.5.1
git rebase to combine the resulting revert commits

Signed-off-by: Dave Rodgman <[email protected]>
…ead-tls

[G3] Driver-only cipher+aead: TLS: main test suite
Clean up libtestdriver1 config: unconditonal removals
@davidhorstmann-arm davidhorstmann-arm force-pushed the dev/davidhorstmann-arm/move-test-code branch from 3c76996 to 46663d5 Compare March 28, 2024 12:20
@davidhorstmann-arm davidhorstmann-arm force-pushed the dev/davidhorstmann-arm/move-test-code branch from 46663d5 to e8a373a Compare April 3, 2024 13:37
@davidhorstmann-arm davidhorstmann-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon and removed needs-work labels Apr 3, 2024
Copy link
Contributor

@Ryan-Everett-arm Ryan-Everett-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced locally with the same result, LGTM!

mpg and others added 4 commits April 8, 2024 08:56
Guard ticket specific TLS 1.3 function with macro
- "in-driver" test should depend on the present
  of a driver.
- add new counter in key manangement driver test
  hook which counts the calls of generate_key.
- We only care about the hits when processing
  `psa_generate_key`.

Signed-off-by: Pengyu Lv <[email protected]>
@davidhorstmann-arm
Copy link
Contributor Author

[Recreated from latest development due to bitrot]

Copy link
Contributor

@Ryan-Everett-arm Ryan-Everett-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,23 @@
/* aes_alt.h with dummy types for MBEDTLS_AES_ALT */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt-dummy is only ever going to apply to 3.6, not to 4.0 or tf-psa-crypto. So I think it should stay in 3.6. (I would normally treat it as framework material, I'm making an exception solely because it's only ever going to apply to a single consuming branch.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.