Move test helper code to the framework repo #8992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhorstmann-arm
added
needs-ci
davidhorstmann-arm
force-pushed
the
move-test-code-to-framework
branch
4 times, most recently
from
d7f5345
to
da24ced
Compare
There was a problem hiding this comment.
I noticed a discrepancy in the lines added by Mbed-TLS/mbedtls-framework#6 and the lines removed by this PR. It seems that the following files have been added to framework but are not yet removed from the base directory:
tests/include/test/psa_memory_poisoning_wrappers.htests/include/test/psa_test_wrappers.htests/src/psa_memory_poisoning_wrappers.ctests/src/psa_test_wrappers.ctests/src/test_memory.c
These are the only files remaining in tests/include/tests/src.
davidhorstmann-arm
force-pushed
the
move-test-code-to-framework
branch
from
da24ced
to
dbec48a
Compare
davidhorstmann-arm
added
needs-review
|
I am also not sure whether this needs a 3.6 backport. The ABI checker hasn't failed here, so perhaps it does. |
Yes, I think this needs a 3.6 backport, I'll make one presently |
davidhorstmann-arm
added
the
needs-backports
4 tasks
davidhorstmann-arm
added
needs-preceding-pr
Signed-off-by: David Horstmann <[email protected]>
Update them instead to refer to framework/include, where the contents of tests/include have been moved. Signed-off-by: David Horstmann <[email protected]>
tests/CMakeLists.txt now refers correctly to framework/include rather than tests/include. Signed-off-by: David Horstmann <[email protected]>
This all.sh component specifies a path directly so needs editing to point into the framework submodule. Signed-off-by: David Horstmann <[email protected]>
These have now been moved to framework/src and framework/include, respectively. Signed-off-by: David Horstmann <[email protected]>
The MBEDTLS_TEST_PATH variable now points into the framework submodule, along with other ad-hoc paths in the Makefiles. Signed-off-by: David Horstmann <[email protected]>
These are references that are part of the PSA shared memory testing work and thus were not previously updated. Signed-off-by: David Horstmann <[email protected]>
Signed-off-by: David Horstmann <[email protected]>
davidhorstmann-arm
force-pushed
the
move-test-code-to-framework
branch
from
5ae844f
to
565be3d
Compare
Ryan-Everett-arm
approved these changes
Apr 10, 2024
| @@ -297,7 +297,7 @@ add_subdirectory(library) | |||
| add_subdirectory(pkgconfig) | |||
|
|
|||
There was a problem hiding this comment.
Missing: apply code_style.py (and more?) to framework files (Mbed-TLS/mbedtls-framework#7).
ronald-cron-arm
added
needs-work
and removed
needs-reviewer
|
Superseded by #9409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the code in
tests/srcandtests/includeto the framework repository.Depends on Mbed-TLS/mbedtls-framework#6
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")