Move test helpers to the framework #9409
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Horstmann <[email protected]>
Update paths that refer to tests/src now that this directory has moved to the framework. Signed-off-by: David Horstmann <[email protected]>
Update paths that refer to tests/include to instead point to the new path, framework/tests/include. Signed-off-by: David Horstmann <[email protected]>
Signed-off-by: David Horstmann <[email protected]>
This includes from tests/include so must be changed to include from tests/../framework/tests/include. Signed-off-by: David Horstmann <[email protected]>
Signed-off-by: David Horstmann <[email protected]>
davidhorstmann-arm
added
needs-review
|
First quick look, this looks overall as expected. I will wait for the CI to be happier to review further though. |
ronald-cron-arm
added
needs-work
and removed
needs-review
|
I will also need to rebase and rework after #9394 I think |
This was referenced Jul 23, 2024
Signed-off-by: David Horstmann <[email protected]>
Update the MBEDTLS_TEST_PATH Makefile variable to point correctly to framework/tests, which contains all of the test helpers and other test sources that are required by the programs. Signed-off-by: David Horstmann <[email protected]>
Update extra paths pointing implicitly or explicitly to tests/src in the tests Makefile. Change them to point to the source files in the framework. Signed-off-by: David Horstmann <[email protected]>
Signed-off-by: David Horstmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the contents of
tests/srcandtests/include(excludingtests/include/alt-dummy) to the framework and adjust references to these paths accordingly.PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.