Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simplication of HTTPOptions across transport, batch transport and offline. #332

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

TheRealAgentK
Copy link
Contributor

#320 - feat: Simplication of HTTPOptions across transport, batch transport and offline.

Description 📝

  • Purpose: Fixes feat: Add configurable timeouts  #320 and limits the creation of unnecessary HTTP information in Promises (via SendOptions)
  • Approach: Make http information optional in the type system and change the various transport layers so that the really relevant transport info is actually being stored/used.

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Updates

👉 SendOptions type has changed
👉 Accordingly change fed through to default transport layer
👉 Main raygun.ts now builds SendOptions depending on batch being set or resp. based on the type of the transport layer being used.
👉 Unrelated side-found: Bugfix to express sample - that was creating an error when used in offline mode.

Test plan 🧪

Tested with Express sample in various combinations of offline/online and batch/no-batch. Additional found was slightly unclear behaviour with offline mode, see separate documentation update PR.

Unit tests all pass.

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@TheRealAgentK
Copy link
Contributor Author

TheRealAgentK commented Oct 22, 2024

@miquelbeltran I can't get tseslint and prettier to work together to fix the indentation of the 8 lines of code it's complaining about in the builds.

I get the same locally, however I seem to try to fix it and move the indentation, it will just revert it back (with its own --fix argument) and then still complain about the indentation.

Do you mind having a look?

It's raygun.ts lines 582-589.

@miquelbeltran miquelbeltran self-assigned this Oct 22, 2024
Copy link
Contributor Author

@TheRealAgentK TheRealAgentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TheRealAgentK TheRealAgentK merged commit 5f181bc into develop Oct 22, 2024
@sumitramanga sumitramanga deleted the feature/#330-batch-http branch December 3, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants