-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Simplication of HTTPOptions across transport, batch transport and offline. #332
Conversation
@miquelbeltran I can't get tseslint and prettier to work together to fix the indentation of the 8 lines of code it's complaining about in the builds. I get the same locally, however I seem to try to fix it and move the indentation, it will just revert it back (with its own Do you mind having a look? It's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
#320 - feat: Simplication of HTTPOptions across transport, batch transport and offline.
Description 📝
SendOptions
)Type of change
Delete options that are not relevant.
Updates
👉
SendOptions
type has changed👉 Accordingly change fed through to default transport layer
👉 Main
raygun.ts
now buildsSendOptions
depending on batch being set or resp. based on the type of the transport layer being used.👉 Unrelated side-found: Bugfix to express sample - that was creating an error when used in offline mode.
Test plan 🧪
Tested with Express sample in various combinations of offline/online and batch/no-batch. Additional found was slightly unclear behaviour with offline mode, see separate documentation update PR.
Unit tests all pass.
Author to check 👓
Reviewer to check ✔️