Skip to content
This repository has been archived by the owner on Apr 23, 2023. It is now read-only.

Add support for Master world saving #2

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Conversation

RemcoSpigot
Copy link
Member

  • Added support for defining volumes and pvcs for the master server

@RemcoSpigot RemcoSpigot requested a review from 1lann June 6, 2022 21:06
Copy link
Member

@1lann 1lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm not sure though about why the_end and the nether are seperate, are they not DIM-1/DIM1 or whatever subfolders in the world directory?

@1lann
Copy link
Member

1lann commented Jun 6, 2022

I personally would just want the entire server directory as a single persistent volume so /op, etc. works.

@RemcoSpigot
Copy link
Member Author

LGTM, I'm not sure though about why the_end and the nether are seperate, are they not DIM-1/DIM1 or whatever subfolders in the world directory?

Unlike normal world saving in Minecraft, the DIM and DIM-1 folders are located in their own world_nether and world_the_end folders. The logic for finding the world directory can be found here.

@RemcoSpigot
Copy link
Member Author

RemcoSpigot commented Jun 7, 2022

I personally would just want the entire server directory as a single persistent volume so /op, etc. works.

This would be great. However for this to work the world folders would have to be in a sub directory relative to the work directory of the container. Otherwise if we would make the entire work directory a volume, it would override the contents and remove the JAR along with it.
For saving the ops.json and other files we should have to find another solution. At least in the future a plugins folder will also be added by default to the values.yaml.

- Added support for defining volumes and pvcs for the master server
@RemcoSpigot RemcoSpigot force-pushed the feature/world-saving branch from f702586 to 69efa59 Compare June 7, 2022 21:31
@RemcoSpigot RemcoSpigot merged commit ee09f33 into master Jun 7, 2022
@RemcoSpigot RemcoSpigot deleted the feature/world-saving branch June 7, 2022 21:32
@1lann
Copy link
Member

1lann commented Jun 7, 2022

Alright, the way I did it in my spec was keep the jar outside of the work folder, and make the entire work folder a volume (i.e. the server runs fine even if the jar is outside of the current directory, it will still store everything in the current directory!)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Move world volumes to a single data volume
2 participants