Fix Urdr panic when user has starred a closed issue #1003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
issues.json
Redmine endpoint does not, by default, return data for closed issues. This means that when a user has starred a Redmine issue that later is closed, Urdr can't find any information about it and panics. The panic is due to accessing the first element from an empty array, which is empty because there was no information from Redmine about the issue, because it was closed.Related issue(s) and PR(s)
This PR closes #1002.
Type of change
List of changes made
This PR allows us to find the project ID for closed Redmine issues that a user has starred in Urdr. This is done by adding
status_id=*
as a query parameter to the relevant REST API call.Screenshot of the fix
Testing
To test: Star a closed issue (for example 7398) and reload. You will have problem seeing your favourites.
With the PR, this should work.
Further comments
Definition of Done checklist