Bump gcc version and use Alpine 3.20 base image #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalananda
force-pushed
the
fix-docker-builds
branch
from
d0a263c
to
3f446d0
Compare
kusalananda
changed the title
This was referenced Sep 6, 2024
pdmnyberg
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR relates to #977.
This PR should fix the automatic Docker image builds that are done by Github actions when we push to the
developbranch. The issue was that theproductionDockerfile tried to install a too-old version of thegcccompiler. This has been resolved, and thebackendDockerfile has been amended to use the samegolangbase image.As suggested by other dependabot PRs, also bump the Go version to 1.23 while we're here.
To test:
Ensure that
docker compose buildsucceeds in both theproductionsubdirectory (where it fails without this PR), and in the main directory.