-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legend 6: Remove legend previews from toolbar #2448
Legend 6: Remove legend previews from toolbar #2448
Conversation
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in NCEAS#2448, so not worth fixing. For now I just reverted the manual changes.
37f7d63
to
d8dab5d
Compare
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in NCEAS#2448, so not worth fixing. For now I just reverted the manual changes.
This container is intended to be a parent for the map and all overlays (ex. legend, scale bar, etc).
To make lint happy
...to MapWidgetContainerView. This is so that this container can be reusable in the future if we swap out the underlying map framework.
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in NCEAS#2448, so not worth fixing. For now I just reverted the manual changes.
d8dab5d
to
e7811f1
Compare
@yvonnesjy do we also want to remove the little image preview from the base layers and other imagery layers? Has there been consideration about keeping those or moving them somewhere else (legend? in place of icon?) |
Hmmm good questions. @hngrtr ? |
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in NCEAS#2448, so not worth fixing. For now I just reverted the manual changes.
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in NCEAS#2448, so not worth fixing. For now I just reverted the manual changes.
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in #2448, so not worth fixing. For now I just reverted the manual changes.
This PR has been moved to #2526, as I had to create a new branch in order to rebase it with develop. |
Deleting the previews as the UX mock suggests. This slack thread has also acked the change.