Legend 6: Remove legend previews from toolbar #2448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnesjy
changed the title
yvonnesjy
added a commit
to yvonnesjy/metacatui
that referenced
this pull request
Jun 13, 2024
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in NCEAS#2448, so not worth fixing. For now I just reverted the manual changes.
yvonnesjy
force-pushed
the
feature-1784-remove-legend-preview
branch
from
37f7d63
to
d8dab5d
Compare
yvonnesjy
added a commit
to yvonnesjy/metacatui
that referenced
this pull request
Jun 13, 2024
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in NCEAS#2448, so not worth fixing. For now I just reverted the manual changes.
This container is intended to be a parent for the map and all overlays (ex. legend, scale bar, etc).
To make lint happy
...to MapWidgetContainerView. This is so that this container can be reusable in the future if we swap out the underlying map framework.
ianguerin
approved these changes
Jun 14, 2024
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in NCEAS#2448, so not worth fixing. For now I just reverted the manual changes.
yvonnesjy
force-pushed
the
feature-1784-remove-legend-preview
branch
from
d8dab5d
to
e7811f1
Compare
|
@yvonnesjy do we also want to remove the little image preview from the base layers and other imagery layers? Has there been consideration about keeping those or moving them somewhere else (legend? in place of icon?) |
Hmmm good questions. @hngrtr ? |
yvonnesjy
added a commit
to yvonnesjy/metacatui
that referenced
this pull request
Jun 17, 2024
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in NCEAS#2448, so not worth fixing. For now I just reverted the manual changes.
yvonnesjy
added a commit
to yvonnesjy/metacatui
that referenced
this pull request
Jun 20, 2024
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in NCEAS#2448, so not worth fixing. For now I just reverted the manual changes.
yvonnesjy
added a commit
that referenced
this pull request
Jun 20, 2024
I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in #2448, so not worth fixing. For now I just reverted the manual changes.
|
This PR has been moved to #2526, as I had to create a new branch in order to rebase it with develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting the previews as the UX mock suggests. This slack thread has also acked the change.