Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legend 6: Remove legend previews from toolbar #2448

Closed
wants to merge 25 commits into from
Closed

Legend 6: Remove legend previews from toolbar #2448

wants to merge 25 commits into from

Commits on Jun 14, 2024

  1. Legend: Create Cesium widget container 

    This container is intended to be a parent for the map and all overlays (ex. legend, scale bar, etc).
    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    187f239 View commit details
    Browse the repository at this point in the history

  2. Fixup: Fix format and lint errors

    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7117237 View commit details
    Browse the repository at this point in the history

  3. Fixup: Remove unused imports from test

    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    eef5a6f View commit details
    Browse the repository at this point in the history

  4. Fixup: Replace @SInCE x.x.x with 0.0.0 

    To make lint happy
    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    63b8190 View commit details
    Browse the repository at this point in the history

  5. Fixup: Rename CesiumWidgetContainerView 

    ...to MapWidgetContainerView. This is so that this container can be reusable in the future if we swap out the underlying map framework.
    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a6d5786 View commit details
    Browse the repository at this point in the history

  6. Fixup: Hide map from the test page DOM

    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    43fd484 View commit details
    Browse the repository at this point in the history

  7. Legend: Create legend components

    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ba7aee8 View commit details
    Browse the repository at this point in the history

  8. Fixup: Fix format and lint errors

    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5b99526 View commit details
    Browse the repository at this point in the history

  9. Fixup: Add screenshots

    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9999f55 View commit details
    Browse the repository at this point in the history

  10. Fixup: Bug fix and address reviewer comments

    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    06d0a03 View commit details
    Browse the repository at this point in the history

  11. Legend: Add legend to map

    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    086b863 View commit details
    Browse the repository at this point in the history

  12. Legend: Render categorical palette

    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    249b0e7 View commit details
    Browse the repository at this point in the history

  13. Fixup: Fix format and lint errors

    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4f27d01 View commit details
    Browse the repository at this point in the history

  14. Fixup: Add screenshot

    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4057d1c View commit details
    Browse the repository at this point in the history

  15. Fixup: Bug fix and address reviewer comment

    @yvonnesjy
    yvonnesjy committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    35d096c View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Fixup: Have legend not obstruct toolbar links

    @yvonnesjy
    yvonnesjy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2666bd9 View commit details
    Browse the repository at this point in the history

  2. Legend: Render continuous palette

    @yvonnesjy
    yvonnesjy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    440c275 View commit details
    Browse the repository at this point in the history

  3. Fixup: Fix format and lint errors

    @yvonnesjy
    yvonnesjy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    91728c0 View commit details
    Browse the repository at this point in the history

  4. Fixup: Add screenshot

    @yvonnesjy
    yvonnesjy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9ed22cc View commit details
    Browse the repository at this point in the history

  5. Fixup: Bug fix in LegendView

    @yvonnesjy
    yvonnesjy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7caf694 View commit details
    Browse the repository at this point in the history

  6. Fixup: Address reviewer comments

    @yvonnesjy
    yvonnesjy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7fca198 View commit details
    Browse the repository at this point in the history

  7. Fixup: Revert manual lint fixups in LegendView 

    I've since noticed a bug and a lambda binding issue with `this` in d3. This file is being removed in NCEAS#2448, so not worth fixing. For now I just reverted the manual changes.
    @yvonnesjy
    yvonnesjy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    1f0b9f2 View commit details
    Browse the repository at this point in the history

  8. Legend: Remove legend previews from toolbar 

    This follows the design mock at https://www.figma.com/design/6bbLaj8VZViuArkhpzMm9M/PDG-Enhancements?node-id=42-2041&t=w060AL3WjPqoZPdD-1
    @yvonnesjy
    yvonnesjy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    6efe406 View commit details
    Browse the repository at this point in the history

  9. Fixup: Fix format and lint errors

    @yvonnesjy
    yvonnesjy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    cd61ec6 View commit details
    Browse the repository at this point in the history

  10. Fixup: Use Object.assign when initializing with options

    @yvonnesjy
    yvonnesjy committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    e7811f1 View commit details
    Browse the repository at this point in the history