Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added openPage in webpack.config.babel.js #65

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

added openPage in webpack.config.babel.js #65

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2017

It doesn't seem to work. What am I doing wrong?

@nkprince007 nkprince007 mentioned this pull request Dec 2, 2017
Closed
@nkprince007
Copy link
Member

And please follow the commit log structure as shown below.

Shortlog: Description of the Commit

Detailed description, if required.

Fixes < full url to the issue e.g.: Fixes https://github.com/nitdgpos/issues/1 >

if your commit fixes some issue, then note in the

nkprince007
nkprince007 requested changes Dec 2, 2017
View reviewed changes
Copy link
Member

@nkprince007 nkprince007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScareCROW21 I don't think this'll work. Please check the comments above and proceed.

@ghost
Copy link
Author

ghost commented Dec 2, 2017

Yes. Didn't see the comments. Will do.

nkprince007
nkprince007 requested changes Dec 3, 2017
View reviewed changes
Copy link
Member

@nkprince007 nkprince007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes noted here.

webpack.config.babel.js
@@ -1,11 +1,11 @@
import path from 'path';
import path from 'path';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary change. Please drop this.

webpack.config.babel.js Outdated
import webpack from 'webpack';

const config = {
devServer: {
hot: true,
inline: true,
openPage: 'https://localhost:8000'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this newline, please.

webpack.config.babel.js
@@ -56,7 +56,8 @@ const config = {
},
output: {
filename: 'bundle.js',
path: path.resolve(__dirname, 'build', 'client')
path: path.resolve(__dirname, 'build', 'client'),
publicPath: "localhost:8080/dev-server/bundle.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"/dev-server" would be enough. You shouldn't be specifying the entire scheme here.

@nkprince007
Copy link
Member

And please never merge master branch into your branches. Keep the commit history linear by rebasing stuff.

@nkprince007
Copy link
Member

And I don't see the need for 6 commits here. We can just do it in two, since it's a minor change.

@nkprince007
Copy link
Member

Also, please use eslint before you push any changes. We follow some coding guidelines here.

@ghost
Copy link
Author

ghost commented Dec 3, 2017

I made a new PR. Tell me if any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkprince007 @theairbend3r