Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added openPage in webpack.config.babel.js #65

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

added openPage in webpack.config.babel.js #65

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3e9e4cb
added openPage in webpack.config.babel.js
theairbend3r Dec 2, 2017
1975651
Automatically open browser when launching devServer
theairbend3r Dec 2, 2017
e916e3c
output.publicPath uses /devServer
theairbend3r Dec 3, 2017
74ab44e
output.publicPath uses /devServer
theairbend3r Dec 3, 2017
28d15a3
proxy index requests to localhost:8000
theairbend3r Dec 3, 2017
1768ab9
Merge branch 'master' into feature/testing
theairbend3r Dec 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions webpack.config.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import path from 'path';
import path from 'path';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary change. Please drop this.

import webpack from 'webpack';

const config = {
devServer: {
hot: true,
inline: true
inline: true,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this newline, please.

},
devtool: 'cheap-module-eval-source-map',
entry: path.resolve(__dirname, 'app', 'main.js'),
Expand Down Expand Up @@ -55,7 +56,8 @@ const config = {
},
output: {
filename: 'bundle.js',
path: path.resolve(__dirname, 'build', 'client')
path: path.resolve(__dirname, 'build', 'client'),
publicPath: "localhost:8080/dev-server/bundle.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"/dev-server" would be enough. You shouldn't be specifying the entire scheme here.

},
plugins: [
new webpack.optimize.OccurrenceOrderPlugin(),
Expand Down