do_diss_est and dycore_only bugfixes #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it a9b5825 in fv3_gfsphysics.
… updates for getting inline physics to work.)
… This also raises a NOTE if do_skeb = .T. and do_diss_est is not .T.
lharris4
requested review from
laurenchilutti and
thomas-robinson
as code owners
bensonr
approved these changes
Feb 21, 2024
7 tasks
laurenchilutti
approved these changes
Jul 11, 2024
|
I can merge this now - Looks like it got forgotten while I was on my maternity leave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two bugs:
do_diss_estflag would be hard-coded to equaldo_skeb, meaning that this would never be enabled if stochastic physics were not turned on.dycore_only=.T.would callmpp_clock_begin(shieldClock)but notmpp_clock_end(shieldClock)in each call toupdate_atmos_pre_radiation(), causing a FATAL error.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist: