Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test results for NOCT model change #1893

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Conversation

mjprilliman
Copy link
Collaborator

Description

-Update test results for change in NOCT model in NREL/ssc#1233

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added pv pvsam1, pvwatts, hcpv dev bug Internal bug that should not be included in release notes labels Oct 30, 2024
@mjprilliman mjprilliman added this to the SAM Fall 2024 Release milestone Oct 30, 2024
@mjprilliman mjprilliman self-assigned this Oct 30, 2024
@mjprilliman mjprilliman merged commit 5dec858 into develop Nov 4, 2024
8 checks passed
@mjprilliman mjprilliman deleted the noct-taualpha branch November 4, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev bug Internal bug that should not be included in release notes pv pvsam1, pvwatts, hcpv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants