Merge pull request #9 from NYPL-discovery/more-verbose-item-errors

Add more descriptive errors, tests

.gitignore

@@ -1,4 +1,3 @@
-event.json
 build/*
 node_modules
 .DS_Store

README.md

@@ -95,12 +95,12 @@ Note that `event.json` contains a sample API Gateway event that can, in theory,
 
 A series of local test fixtures representing responses from the nypl data api, maintained in `./test/data/*.json`. These allow the test suite to run against a fixed set of data. If any fixtures need to be updated or added, a script is provided:
 
-`node scripts/update-test-fixtures [--all|PATH] --envfile config/[environment].env --profile [aws profile]`
+`./scripts/update-test-fixtures [--all|PATH] --envfile config/[environment].env --profile [aws profile]`
 
 For example, to populate a test fixture for the api response for 'bibs/sierra-nypl/123':
 
-`node scripts/update-test-fixtures bibs/sierra-nypl/123 --envfile config/[environment].env --profile [aws profile]`
+`./scripts/update-test-fixtures bibs/sierra-nypl/123 --envfile config/[environment].env --profile [aws profile]`
 
 To update ALL of the test fixtures:
 
-`node scripts/update-test-fixtures --all --envfile config/[environment].env --profile [aws profile]`
+`./scripts/update-test-fixtures --all --envfile config/[environment].env --profile [aws profile]`

lib/data-api.js

@@ -50,7 +50,7 @@ class DataApi {
             return bibIds
           } else {
             logger.error({'message': 'Error calling ' + url, response: resp})
-            return Promise.reject(new errors.NotFoundError('Barcode not found'))
+            return Promise.reject(new errors.NotFoundError('Barcode not found in ItemService'))
           }
         })
     })

lib/scsb-xml-formatter.js

@@ -34,7 +34,11 @@ function bibsAndItemsToScsbXml (bibs, items, customerCode = 'NA') {
   if (itemCount === 0) {
     logger.error({'message': 'Error generating SCSB XML', response: items})
 
-    throw new errors.NoItemsError('No items would be sent to ReCAP')
+    // It's possible all of the items passed in are not valid for export to recap
+    // There are several conditions that can cause this, including invalid location.
+    // Here's where they're checked:
+    // https://github.com/NYPL-discovery/convert-2-scsb-module/blob/3a891df24f5358c9403b074e60c81291fb1c3516/lib/parsemrc.js#L440-L505
+    throw new errors.NoItemsError('SCSB XML Formatter determined that no items were suitable for export to Recap')
   }
 
   if (scsbXml.length === 0) throw new errors.ScsbXmlGenerationError('Error parsing API into SCSB XML')