Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build spec requestable #430

Merged

Conversation

charmingduchess
Copy link
Contributor

@charmingduchess charmingduchess commented Dec 19, 2024

  • expand specRequestable criteria to include finding aids and locations with collectionAccessType === "special"
  • write tests
  • add override so spec requestable items are never physically requestable

Copy link
Member

@nonword nonword left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right

app.js Outdated
@@ -20,6 +20,7 @@ const app = express()
app.set('trust proxy', 'loopback')

app.init = async () => {
console.log('heeeeere')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@charmingduchess charmingduchess merged commit dfa867e into noref-nypl-core-objects-async Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants