-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update build spec requestable #430
Merged
charmingduchess
merged 16 commits into
noref-nypl-core-objects-async
from
SCC-4286/update-spec-requestable
Dec 20, 2024
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3b3db65
update build spec requestable
charmingduchess 0fbfb32
write tests for specRequestable
charmingduchess 1293896
make collectionaccesstype explicit;
charmingduchess 948fb18
rm console logs
charmingduchess d64a44e
update nyplcore version
charmingduchess ee0e34c
Merge branch 'noref-nypl-core-objects-async' into SCC-4286/update-spe…
charmingduchess 76a75bc
account for variable casing of finding aid
charmingduchess aebc0b8
make spec mutually exclusive with edd and physRequestable
charmingduchess d64686e
comments and ternary update
charmingduchess ef7b80f
add spec requestable override criteria
charmingduchess 7877170
update this with class name
charmingduchess ea70169
tests for phys requestable override
charmingduchess 8b164e8
fix comment
charmingduchess b3447a8
rm console.log
charmingduchess 1a1ae1d
add specRequest override to eddRequestable
charmingduchess c367443
rm console.log
charmingduchess File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
152 changes: 152 additions & 0 deletions
152
test/fixtures/specRequestable/findingAid-es-response.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| module.exports = () => { | ||
| return { | ||
| _shards: { | ||
| failed: 0, | ||
| successful: 1, | ||
| total: 1 | ||
| }, | ||
| took: 1, | ||
| hits: { | ||
| total: 1, | ||
| max_score: 1.3862944, | ||
| hits: [ | ||
| { | ||
| _id: 'b10980129', | ||
| _source: { | ||
| supplementaryContent: [{ | ||
| label: 'Finding aid', | ||
| url: 'spaghetti.com' | ||
| }], | ||
| items: [ | ||
| { | ||
| holdingLocation: [ | ||
| { | ||
| label: 'OFFSITE - Request in Advance', | ||
| id: 'loc:rc2ma' | ||
| } | ||
| ], | ||
| status_packed: [ | ||
| 'status:na||Not Available' | ||
| ], | ||
| owner: [ | ||
| { | ||
| id: 'orgs:1000', | ||
| label: 'Stephen A. Schwarzman Building' | ||
| } | ||
| ], | ||
| deliveryLocation: [ | ||
| { | ||
| id: 'loc:mala', | ||
| label: 'SASB - Allen Scholar Room' | ||
| } | ||
| ], | ||
| deliveryLocation_packed: [ | ||
| 'loc:mala||SASB - Allen Scholar Room' | ||
| ], | ||
| uri: 'i10283664', | ||
| accessMessage_packed: [ | ||
| 'accessMessage:2||ADV REQUEST' | ||
| ], | ||
| accessMessage: [ | ||
| { | ||
| id: 'accessMessage:2', | ||
| label: 'ADV REQUEST' | ||
| } | ||
| ], | ||
| status: [ | ||
| { | ||
| id: 'status:na', | ||
| label: 'Not available' | ||
| } | ||
| ], | ||
| owner_packed: [ | ||
| 'orgs:1000||Stephen A. Schwarzman Building' | ||
| ], | ||
| requestable: [ | ||
| false | ||
| ], | ||
| identifier: [ | ||
| 'urn:barcode:1000546836' | ||
| ], | ||
| holdingLocation_packed: [ | ||
| 'loc:rc2ma||OFFSITE - Request in Advance' | ||
| ], | ||
| shelfMark: [ | ||
| '*OFC 90-2649' | ||
| ], | ||
| suppressed: [ | ||
| false | ||
| ] | ||
| }, | ||
| { | ||
| holdingLocation: [ | ||
| { | ||
| label: 'OFFSITE - Request in Advance', | ||
| id: 'loc:rc2ma' | ||
| } | ||
| ], | ||
| status_packed: [ | ||
| 'status:a||Available' | ||
| ], | ||
| owner: [ | ||
| { | ||
| id: 'orgs:1000', | ||
| label: 'Stephen A. Schwarzman Building' | ||
| } | ||
| ], | ||
| deliveryLocation: [ | ||
| { | ||
| id: 'loc:mala', | ||
| label: 'SASB - Allen Scholar Room' | ||
| } | ||
| ], | ||
| deliveryLocation_packed: [ | ||
| 'loc:mala||SASB - Allen Scholar Room' | ||
| ], | ||
| uri: 'i102836649', | ||
| accessMessage_packed: [ | ||
| 'accessMessage:2||ADV REQUEST' | ||
| ], | ||
| accessMessage: [ | ||
| { | ||
| id: 'accessMessage:2', | ||
| label: 'ADV REQUEST' | ||
| } | ||
| ], | ||
| status: [ | ||
| { | ||
| id: 'status:a', | ||
| label: 'Available' | ||
| } | ||
| ], | ||
| owner_packed: [ | ||
| 'orgs:1000||Stephen A. Schwarzman Building' | ||
| ], | ||
| requestable: [ | ||
| false | ||
| ], | ||
| identifier: [ | ||
| 'urn:barcode:10005468369' | ||
| ], | ||
| holdingLocation_packed: [ | ||
| 'loc:rc2ma||OFFSITE - Request in Advance' | ||
| ], | ||
| shelfMark: [ | ||
| '*OFC 90-2649 2' | ||
| ], | ||
| suppressed: [ | ||
| false | ||
| ] | ||
| } | ||
| ] | ||
|
|
||
| }, | ||
| _type: 'resource', | ||
| _index: 'resources-2017-06-13', | ||
| _score: 154.93451 | ||
| } | ||
| ] | ||
| }, | ||
| timed_out: false | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove