SCC-3897 - Search Results Electronic Resources Link #55
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| {bib.materialType && <Text>{bib.materialType}</Text>} | ||
| {bib.publicationStatement && <Text>{bib.publicationStatement}</Text>} | ||
| {bib.yearPublished && <Text>{bib.yearPublished}</Text>} | ||
| <Text>{bib.itemMessage}</Text> | ||
| </Box> | ||
| {bib.electronicResources && ( |
There was a problem hiding this comment.
In the Vercel preview, all bib search results are displaying the ElectronicResourcesLink and that's not what true for the same searches in production. Something seems to be off.
There was a problem hiding this comment.
I think the issue can be addressed here
There should be a check for
electronicResources?.length because an empty array is truthy.
There was a problem hiding this comment.
Just added a helper function hasElectronicResources that checks for the length. This resolves the issue.
| </DSLink> | ||
| ) : ( | ||
| <RCLink href={`${bibUrl}#electronic-resources`}> | ||
| <Text |
There was a problem hiding this comment.
Don't render p tags inside links.
In this case, I think this block can be a Link with DS type of "standalone" https://nypl.github.io/nypl-design-system/reservoir/v2/?path=/story/components-navigation-link--with-controls&args=type:standalone
This will render the arrow for you.
dgcohen
changed the title
Ticket: https://jira.nypl.org/browse/SCC-3897
This PR adds the ElectronicResourcesLink component that is mostly derived from the ElectronicResourcesResultsItem component in DFE, with a few minor adjustments.