SFR-2416: Run e2e tests on local domain #569
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jackiequach
changed the title
jackiequach
requested review from
samanthaandrews and
kylevillegas93
as code owners
playwright/integration/auth.spec.ts
Outdated
| @@ -14,7 +14,7 @@ test.beforeEach(async ({ context }) => { | |||
| test.afterEach(() => server.resetHandlers()); | |||
| test.afterAll(() => server.close()); | |||
|
|
|||
| test.describe("Cookie authentication", () => { | |||
| test.skip("Cookie authentication", () => { | |||
There was a problem hiding this comment.
does this test still not pass? should we skip?
There was a problem hiding this comment.
The tests didn't pass due to a double redirect for the login.nypl.org page. I updated the tests to check for the final destination.
| @@ -15,6 +15,19 @@ jobs: | |||
| with: | |||
| node-version-file: ".nvmrc" | |||
|
|
|||
| - name: Set environment for branch | |||
| run: | | |||
| if [[ $GITHUB_REF_NAME == 'production' ]]; then | |||
There was a problem hiding this comment.
should this be [[ $GITHUB_REF_NAME == 'development' ]]?
There was a problem hiding this comment.
since we talked about getting rid of the produciton/development branches and just using main for full CI/CD i'm wondering if this makes sense to use as a check. is there another check we could use?
There was a problem hiding this comment.
definitely agree we should change the branch structure eventually.
@jackiequach - just double checking on the logic here. Should we use drb-qa.nypl.org for production github ref?
There was a problem hiding this comment.
These should run when there's a PR merging into the production branch, so before release.
Jira Ticket
This PR does the following:
Testing requirements & instructions: