SFR-2416: Run e2e tests on local domain

.github/workflows/Playwright.yml

@@ -15,6 +15,19 @@ jobs:
         with:
           node-version-file: ".nvmrc"
 
+      - name: Set environment for branch
+        run: |
+          if [[ $GITHUB_REF_NAME == 'production' ]]; then
+              echo "BASE_URL=https://drb-qa.nypl.org/" >> "$GITHUB_ENV"
+          else
+              echo "BASE_URL=http://local.nypl.org:3000/" >> "$GITHUB_ENV"
+          fi
+
+      - name: Add hosts to /etc/hosts
+        if: github.ref != 'production'
+        run: |
+          sudo echo "127.0.0.1 local.nypl.org" | sudo tee -a /etc/hosts
+
       - name: Install Test Dependencies
         run: npm i @cucumber/[email protected] @playwright/[email protected]
 
@@ -25,6 +38,7 @@ jobs:
         run: NODE_ENV=test npm run build
 
       - name: Start the app
+        if: github.ref != 'production'
         run: |
           NODE_ENV=test npm start &
           sleep 5
@@ -36,7 +50,7 @@ jobs:
       - name: Set the world parameters as an env var
         # WORLD_PARAMETERS set here will override anything set in cucumber.json
         run: |
-          echo "WORLD_PARAMETERS={\"headless\": true}" >> $GITHUB_ENV
+          echo "WORLD_PARAMETERS={\"appUrl\": \"$BASE_URL\", \"headless\": true}" >> $GITHUB_ENV
 
       - name: Run Cucumber tests
         run: npm run cucumber -- playwright/features --world-parameters '${{ env.WORLD_PARAMETERS }}'

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## [Prerelease]
 
+- Update GH action to run tests against local.nypl.org and QA for prod PRs
+
 ## [0.18.10]
 
 - Remove Kristo, Jiayong, and Olivia and add Kyle as codeowners

mocks/mockEnv.ts

@@ -1,4 +1,4 @@
-export const NYPL_LOGIN_URL = "https://login.nypl.org/auth/login?redirect_uri=";
+export const NYPL_LOGIN_URL = "login.nypl.org";
 export const API_URL = "https://backend.msw";
 export const FULFILL_PATH = "/fulfill/9351827";
 export const LIMITED_ACCESS_EDITION_PATH = "/edition/6977884";

playwright.config.ts

@@ -22,7 +22,7 @@ const config: PlaywrightTestConfig = {
   use: {
     headless: true,
     // Base URL to use in actions like `await page.goto('/')`.
-    baseURL: "http://localhost:3000",
+    baseURL: process.env.BASE_URL,
 
     /* When running tests locally, record a trace for each test, but remove it from successful runs.
      * On CI, turn this feature off. See https://playwright.dev/docs/trace-viewer */

playwright/features/edd.feature

@@ -4,5 +4,11 @@ Feature: EDD Request Process
         Given I go to the "home" page
         When I fill in the "homepage search box" with "Africa"
         And I click the "search button"
-        And I click the "requestable checkbox"
-        Then the "first login for options button" should be displayed
+        And I click the "requestable checkbox"        
+        And I click the "first login for options button"
+        And I fill in the "username field" with "catalog username"
+        And I fill in the "password field" with "catalog password"
+        And I click the "login button"
+        And the "first request button" should be displayed
+        And I click the "first request button"
+        Then the "delivery location heading" should be displayed

playwright/integration/auth.spec.ts

@@ -15,14 +15,14 @@ test.afterEach(() => server.resetHandlers());
 test.afterAll(() => server.close());
 
 test.describe("Cookie authentication", () => {
-  test("redirects to NYPL log in page with no cookie", async ({ page }) => {
+  test("redirects to NYPL login page with no cookie", async ({ page }) => {
     await page.goto(`${LIMITED_ACCESS_EDITION_PATH}`);
     await page.getByTestId(LOGIN_TO_READ_TEST_ID).click();
-    await page.waitForURL(`**${NYPL_LOGIN_URL}**`);
+    await page.waitForURL(/.*login.nypl.org.*/);
     const url = new URL(page.url());
-    const redirectUri = url.searchParams.get("redirect_uri");
+    const service = url.searchParams.get("service");
 
-    expect(redirectUri).toContain(LIMITED_ACCESS_EDITION_PATH);
+    expect(service).toContain(NYPL_LOGIN_URL);
   });
 
   test("redirects to NYPL login page with expired cookie", async ({
@@ -34,11 +34,11 @@ test.describe("Cookie authentication", () => {
 
     await page.goto(`${LIMITED_ACCESS_EDITION_PATH}`);
     await page.getByTestId(LOGIN_TO_READ_TEST_ID).click();
-    await page.waitForURL(`**${NYPL_LOGIN_URL}**`);
+    await page.waitForURL(/.*login.nypl.org.*/);
     const url = new URL(page.url());
-    const redirectUri = url.searchParams.get("redirect_uri");
+    const service = url.searchParams.get("service");
 
-    expect(redirectUri).toContain(LIMITED_ACCESS_EDITION_PATH);
+    expect(service).toContain(NYPL_LOGIN_URL);
   });
 
   // TODO: logging in from localhost does not work