Draft: Create rubyonrails.yml #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factory girl is deprecated and this will start the process of cleaning deprecation notices in prep for eventually upgrading to Rails 4.1!
bagedevimo
force-pushed
the
gh-actions
branch
from
364e812
to
31ee4e7
Compare
|
We are considering to remove maxmind, see #108.
|
I love the idea of dropping it but I'm going to try get this working with as fewer code changes as possible, because then I can be more confident about future changes like dropping maxmind knowing that CI has my back :) |
|
I love the idea of dropping it but I'm going to try get this working with
as fewer code changes as possible, because then I can be more confident
about future changes like dropping maxmind knowing that CI has my back :)
Okay, but beware that maxmind is currently broken (breaks sign up form --
see linked issue; CI should still pass because the specs don't cover
that...)
Also, see #82 for an earlier PR for using GitHub Actions (I haven't
reviewed it yet).
|
bagedevimo
force-pushed
the
gh-actions
branch
3 times, most recently
from
7ea5f6c
to
2c1748f
Compare
These appear to be unused, and are certainly broken. Commit messages don't paint a clear picture of why they are there and they have gone a long time since they were last actually edited in a meaningful way. Closes NZOI#152.
This newer version workers with older system libraries (as far as I can tell) and workers with new ruby / rails versions so is a requirement for eventually upgrading Rails
May need to revist how database.yml is now in the repo, depending on how the application is deployed. Modern rails practises just leave database.yml in the repo, but maybe in Rails 4.x or however the app is setup in production this might be the wrong choice.
Ruby 2.3 and 2.4 when built against specific versions of libpg have a crash related to resolv() calls. Good times.
It appears to be glitching in postgres11/pg<1 We can upgrade our postgresql server after we upgrade rails.
bagedevimo
force-pushed
the
gh-actions
branch
from
2c1748f
to
271d3f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.