Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Create rubyonrails.yml #150

Closed
wants to merge 20 commits into from
Closed

Draft: Create rubyonrails.yml #150

wants to merge 20 commits into from

Commits on Feb 7, 2023

  1. Update factory-girl to factory-bot. 

    Factory girl is deprecated and this will start the process of cleaning
deprecation notices in prep for eventually upgrading to Rails 4.1!
    @bagedevimo
    bagedevimo committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    2613a7d View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Drop references the NZIC module, remove the NZIC models from the bundle 

    These appear to be unused, and are certainly broken. Commit messages
don't paint a clear picture of why they are there and they have gone a
long time since they were last actually edited in a meaningful way.

Closes NZOI#152.
    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    8c6fa93 View commit details
    Browse the repository at this point in the history

  2. Drop most forem, replace with placeholder page to avoid dead lines

    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    2ef2212 View commit details
    Browse the repository at this point in the history

  3. Upgrade rmagick 

    This newer version workers with older system libraries (as far as I can
tell) and workers with new ruby / rails versions so is a requirement for
eventually upgrading Rails
    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f0c0aae View commit details
    Browse the repository at this point in the history

  4. Create rubyonrails.yml

    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9ec0816 View commit details
    Browse the repository at this point in the history

  5. Add a .tool-versions to configure the recommended Ruby version

    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f6f1e2a View commit details
    Browse the repository at this point in the history

  6. Install the libmaxmind libraries

    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    a94ef74 View commit details
    Browse the repository at this point in the history

  7. Fix invocations for schema:load & rspec runs

    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    7d1d488 View commit details
    Browse the repository at this point in the history

  8. Configure the databases for running in GitHub Actions 

    May need to revist how database.yml is now in the repo, depending on how
the application is deployed. Modern rails practises just leave
database.yml in the repo, but maybe in Rails 4.x or however the app is
setup in production this might be the wrong choice.
    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    24cf854 View commit details
    Browse the repository at this point in the history

  9. Use 127.0.0.1 instead of localhost for specifiying DATABASE_URL 

    Ruby 2.3 and 2.4 when built against specific versions of libpg have a
crash related to resolv() calls. Good times.
    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    a63c882 View commit details
    Browse the repository at this point in the history

  10. Disable PostgreSQL gssencmode 

    It appears to be glitching in postgres11/pg<1

We can upgrade our postgresql server after we upgrade rails.
    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    69198d0 View commit details
    Browse the repository at this point in the history

  11. Use non-alpine postgresql images to avoid incompat issues between muslc 

    and glibc
    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    482c96c View commit details
    Browse the repository at this point in the history

  12. fixup! Configure the databases for running in GitHub Actions

    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    221eda6 View commit details
    Browse the repository at this point in the history

  13. Split the db:create and db:schema:load steps to help spot issues

    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    71041c3 View commit details
    Browse the repository at this point in the history

  14. Add a redis server and config

    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f4d10d8 View commit details
    Browse the repository at this point in the history

  15. Use ubuntu-18.04 instead of ubuntu-22.04

    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    037e902 View commit details
    Browse the repository at this point in the history

  16. Try using more database config defaults specified earlier

    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    768dbe9 View commit details
    Browse the repository at this point in the history

  17. Use a direct redis config variable - the redis.conf isn't read with e… 

    …rb support
    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    a25bd23 View commit details
    Browse the repository at this point in the history

  18. See if we can get further without doing db:create

    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    d6be9be View commit details
    Browse the repository at this point in the history

  19. Bump the ruby version in case it fixes the pg issues

    @bagedevimo
    bagedevimo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    271d3f6 View commit details
    Browse the repository at this point in the history