Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatible with Java 11 #168

Closed
wants to merge 1 commit into from
Closed

Make compatible with Java 11 #168

wants to merge 1 commit into from

Conversation

fbruton
Copy link
Collaborator

@fbruton fbruton commented Jul 27, 2021

No description provided.

@fbruton fbruton force-pushed the java-11-compatible branch from 4851cbf to d94176a Compare July 27, 2021 02:19
@fbruton fbruton requested review from drewfarris and jpdahlke July 27, 2021 02:20
@drivenflywheel drivenflywheel self-requested a review September 21, 2021 19:20
@drivenflywheel
Copy link
Collaborator

drivenflywheel commented Sep 21, 2021 •
edited
Loading

Which JDK11 has this been tested with? Do we have a prescribed release? (OpenJDK, Amazon Corretto, ...)

(EDIT: minimally, it's been tested with Adopt JDK 11.0.11+9, via the CI build.)

@drivenflywheel
Copy link
Collaborator

What's the relationship between this PR and #122? This PR was opened the same day that #122 was renamed from "Java 11 upgrade". Is there a dependency between the two?

@drivenflywheel
Copy link
Collaborator

(Closed accidentally because this UI puts buttons with very different intents directly next to each other. Now Reopened.)

@drivenflywheel
Copy link
Collaborator

I'll create a separate PR to address CodeQL findings. The only outstanding issue I see is for this PR is that we need to update contrib/docker/Dockerfile to install java-11-openjdk instead of java-1.8.0-openjdk. (I've tested this on my own workstation and Emissary works correctly.)

drivenflywheel
drivenflywheel requested changes Sep 28, 2021
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the Dockerfile to specify java-11-openjdk instead of java-1.8.0-openjdk

@dev-mlb dev-mlb modified the milestone: v8.0.0 Oct 19, 2021
@jpdahlke jpdahlke added this to the v8.0.0 milestone Jan 4, 2022
@jpdahlke jpdahlke added the integration A breaking change where effort will be required downstream to resolve label Jan 4, 2022
@ukengineer925 ukengineer925 mentioned this pull request Feb 23, 2022
Closed
4 tasks
@dev-mlb dev-mlb mentioned this pull request May 11, 2022
Closed
@cfkoehler cfkoehler added the major Change will go out in a major version increase label Dec 15, 2022
@jpdahlke jpdahlke modified the milestones: v8.0.0, v8.0.0-M1 Jun 24, 2023
@jpdahlke
Copy link
Collaborator

Closing in favor of #252

@jpdahlke jpdahlke closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drivenflywheel drivenflywheel drivenflywheel requested changes

@drewfarris drewfarris Awaiting requested review from drewfarris

@jpdahlke jpdahlke Awaiting requested review from jpdahlke

Assignees
No one assigned
Labels
integration A breaking change where effort will be required downstream to resolve major Change will go out in a major version increase
Projects
None yet
Milestone
v8.0.0-M1
Development

Successfully merging this pull request may close these issues.
5 participants
@fbruton @drivenflywheel @jpdahlke @dev-mlb @cfkoehler