Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return in addmul! #1541

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

felix-roehrich
Copy link
Contributor

Dispatches of addmul! returned different values depending on type. The returned value is now uniform for all dispatches.

Copy link
Collaborator

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! These are now consistent with the other methods, e.g.

Nemo.jl/src/flint/fmpz.jl

Lines 2619 to 2623 in f89c878

function addmul!(z::ZZRingElem, x::ZZRingElem, y::ZZRingElem)
ccall((:fmpz_addmul, libflint), Nothing,
(Ref{ZZRingElem}, Ref{ZZRingElem}, Ref{ZZRingElem}), z, x, y)
return z
end

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #1541 (aba78cb) into master (f89c878) will increase coverage by 0.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1541      +/-   ##
==========================================
+ Coverage   83.79%   84.03%   +0.24%     
==========================================
  Files          94       94              
  Lines       36610    36613       +3     
==========================================
+ Hits        30678    30769      +91     
+ Misses       5932     5844      -88     
Files Coverage Δ
src/arb/arb.jl 88.30% <0.00%> (+0.44%) ⬆️
src/flint/fmpz_mat.jl 89.55% <0.00%> (ø)

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thofma
Copy link
Member

thofma commented Sep 26, 2023

Merci

@thofma thofma merged commit 8975b60 into Nemocas:master Sep 26, 2023
14 of 15 checks passed
@felix-roehrich felix-roehrich deleted the fr-fix-addmul-return branch September 27, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants